2018-07-17 14:00:44 +00:00
|
|
|
|
Payment channel implementation sketch
|
2018-07-08 22:09:07 +00:00
|
|
|
|
|
|
|
|
|
|
Simplifications:
|
|
|
|
|
|
|
|
|
|
|
|
- unidirectional paychans
|
|
|
|
|
|
- no top ups or partial withdrawals (only opening and closing)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
TODO
|
2018-09-01 18:37:10 +00:00
|
|
|
|
- in code TODOs
|
|
|
|
|
|
- Tidy up - method descriptions, heading comments, remove uneccessary comments, README/docs
|
2018-08-27 21:58:58 +00:00
|
|
|
|
- Find a better name for Queue - clarify distinction between int slice and abstract queue concept
|
2018-09-01 18:37:10 +00:00
|
|
|
|
- write some sort of integration test
|
2018-09-02 02:22:50 +00:00
|
|
|
|
- possible bug in submitting same update repeatedly
|
2018-09-01 17:16:56 +00:00
|
|
|
|
- find nicer name for payout
|
2018-09-01 18:37:10 +00:00
|
|
|
|
- add Gas usage
|
|
|
|
|
|
- add tags (return channel id on creation)
|
2018-09-01 20:41:40 +00:00
|
|
|
|
- refactor cmds to be able to test them, then test them
|
2018-09-02 02:22:50 +00:00
|
|
|
|
- verify doesn’t throw json parsing error on invalid json
|
|
|
|
|
|
- can’t submit an update from an unitialised account
|
|
|
|
|
|
- pay without a --from returns confusing error
|
2018-09-01 18:37:10 +00:00
|
|
|
|
- use custom errors instead of using sdk.ErrInternal
|
|
|
|
|
|
- split off signatures from update as with txs/msgs - testing easier, code easier to use, doesn't store sigs unecessarily on chain
|
2018-09-01 17:16:56 +00:00
|
|
|
|
- consider removing pubKey from UpdateSignature - instead let channel module access accountMapper
|
|
|
|
|
|
- remove printout from tests when app initialised
|
2018-09-01 18:37:10 +00:00
|
|
|
|
- refactor queue into one object
|
