smeb_y/ceremonyclient
1
0
Fork 0
mirror of https://source.quilibrium.com/quilibrium/ceremonyclient.git synced 2024-12-26 00:25:17 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: infinite loop edge case

Browse Source
This commit is contained in:
Cassandra Heart 2024-01-10 22:42:11 -06:00
parent f48f177a10
commit 916a1514f1
No known key found for this signature in database
GPG Key ID: 6352152859385958
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
node/consensus/ceremony/consensus_frames.go
View File

@ -1091,7 +1091,15 @@ func (e *CeremonyDataClockConsensusEngine) collect(
latest = e.previousHead latest = e.previousHead
e.syncingStatus = SyncStatusNotSyncing e.syncingStatus = SyncStatusNotSyncing
} }
for {
// With large networks and slow syncing machines, this can lead to an
// infinite loop if the list is refreshing fast enough, so make the size
// of the map the maximum loop case:
e.peerMapMx.Lock()
size := len(e.peerMap)
e.peerMapMx.Unlock()
for i := 0; i < size; i++ {
peerId, maxFrame, err := e.GetMostAheadPeer() peerId, maxFrame, err := e.GetMostAheadPeer()
if err != nil { if err != nil {
e.logger.Warn("no peers available, skipping sync") e.logger.Warn("no peers available, skipping sync")