0g-chain/x/pricefeed/keeper/keeper_test.go
Robert Pirtle af611ca8e1
(v0.26 <- #1851) Optimize Pricefeed EndBlocker (#1895)
* Optimize Pricefeed EndBlocker (#1851)

* optimize pricefeed endblocker to iterate all markets only once to remove
overhead of opening and closing iterator for each market individually.
In addition, extend tests to cover 100% of abci and price updating
behavior.

* use test cases that can't be confused with mean to ensure median is
always used

* update kvtool to master branch

* update changelog

---------

Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
2024-05-29 15:44:53 -07:00

272 lines
7.4 KiB
Go

package keeper_test
import (
"errors"
"testing"
"time"
"github.com/stretchr/testify/require"
sdk "github.com/cosmos/cosmos-sdk/types"
tmprototypes "github.com/cometbft/cometbft/proto/tendermint/types"
"github.com/kava-labs/kava/app"
"github.com/kava-labs/kava/x/pricefeed/keeper"
"github.com/kava-labs/kava/x/pricefeed/testutil"
"github.com/kava-labs/kava/x/pricefeed/types"
)
// TestKeeper_SetGetMarket tests adding markets to the pricefeed, getting markets from the store
func TestKeeper_SetGetMarket(t *testing.T) {
tApp := app.NewTestApp()
ctx := tApp.NewContext(true, tmprototypes.Header{})
keeper := tApp.GetPriceFeedKeeper()
mp := types.Params{
Markets: []types.Market{
{MarketID: "tstusd", BaseAsset: "tst", QuoteAsset: "usd", Oracles: []sdk.AccAddress{}, Active: true},
},
}
keeper.SetParams(ctx, mp)
markets := keeper.GetMarkets(ctx)
require.Equal(t, len(markets), 1)
require.Equal(t, markets[0].MarketID, "tstusd")
_, found := keeper.GetMarket(ctx, "tstusd")
require.True(t, found, "market should be found")
_, found = keeper.GetMarket(ctx, "invalidmarket")
require.False(t, found, "invalidmarket should not be found")
mp = types.Params{
Markets: []types.Market{
{MarketID: "tstusd", BaseAsset: "tst", QuoteAsset: "usd", Oracles: []sdk.AccAddress{}, Active: true},
{MarketID: "tst2usd", BaseAsset: "tst2", QuoteAsset: "usd", Oracles: []sdk.AccAddress{}, Active: true},
},
}
keeper.SetParams(ctx, mp)
markets = keeper.GetMarkets(ctx)
require.Equal(t, len(markets), 2)
require.Equal(t, markets[0].MarketID, "tstusd")
require.Equal(t, markets[1].MarketID, "tst2usd")
_, found = keeper.GetMarket(ctx, "nan")
require.Equal(t, found, false)
}
// TestKeeper_GetSetPrice Test Posting the price by an oracle
func TestKeeper_GetSetPrice(t *testing.T) {
_, addrs := app.GeneratePrivKeyAddressPairs(2)
tApp := app.NewTestApp()
ctx := tApp.NewContext(true, tmprototypes.Header{})
keeper := tApp.GetPriceFeedKeeper()
mp := types.Params{
Markets: []types.Market{
{MarketID: "tstusd", BaseAsset: "tst", QuoteAsset: "usd", Oracles: []sdk.AccAddress{}, Active: true},
},
}
keeper.SetParams(ctx, mp)
prices := []struct {
oracle sdk.AccAddress
marketID string
price sdk.Dec
total int
}{
{addrs[0], "tstusd", sdk.MustNewDecFromStr("0.33"), 1},
{addrs[1], "tstusd", sdk.MustNewDecFromStr("0.35"), 2},
{addrs[0], "tstusd", sdk.MustNewDecFromStr("0.37"), 2},
}
for _, p := range prices {
// Set price by oracle 1
pp, err := keeper.SetPrice(
ctx,
p.oracle,
p.marketID,
p.price,
time.Now().UTC().Add(1*time.Hour),
)
require.NoError(t, err)
// Get raw prices
rawPrices := keeper.GetRawPrices(ctx, "tstusd")
require.Equal(t, p.total, len(rawPrices))
require.Contains(t, rawPrices, pp)
// Find the oracle and require price to be same
for _, rp := range rawPrices {
if p.oracle.Equals(rp.OracleAddress) {
require.Equal(t, p.price, rp.Price)
}
}
}
}
// TestKeeper_GetSetCurrentPrice Test Setting the median price of an Asset
func TestKeeper_GetSetCurrentPrice(t *testing.T) {
_, addrs := app.GeneratePrivKeyAddressPairs(5)
tApp := app.NewTestApp()
ctx := tApp.NewContext(true, tmprototypes.Header{}).
WithBlockTime(time.Now().UTC())
keeper := tApp.GetPriceFeedKeeper()
mp := types.Params{
Markets: []types.Market{
{MarketID: "tstusd", BaseAsset: "tst", QuoteAsset: "usd", Oracles: []sdk.AccAddress{}, Active: true},
},
}
keeper.SetParams(ctx, mp)
_, err := keeper.SetPrice(
ctx, addrs[0], "tstusd",
sdk.MustNewDecFromStr("0.33"),
time.Now().Add(time.Hour*1))
require.NoError(t, err)
_, err = keeper.SetPrice(
ctx, addrs[1], "tstusd",
sdk.MustNewDecFromStr("0.35"),
time.Now().Add(time.Hour*1))
require.NoError(t, err)
_, err = keeper.SetPrice(
ctx, addrs[2], "tstusd",
sdk.MustNewDecFromStr("0.34"),
time.Now().Add(time.Hour*1))
require.NoError(t, err)
// Add an expired one which should fail
_, err = keeper.SetPrice(
ctx, addrs[3], "tstusd",
sdk.MustNewDecFromStr("0.9"),
ctx.BlockTime().Add(-time.Hour*1))
require.Error(t, err)
// Add a non-expired price, but will not be counted when BlockTime is changed
_, err = keeper.SetPrice(
ctx, addrs[3], "tstusd",
sdk.MustNewDecFromStr("0.9"),
time.Now().Add(time.Minute*30))
require.NoError(t, err)
// Update block time such that first 3 prices valid but last one is expired
ctx = ctx.WithBlockTime(time.Now().Add(time.Minute * 45))
// Set current price
err = keeper.SetCurrentPrices(ctx, "tstusd")
require.NoError(t, err)
// Get current price
price, err := keeper.GetCurrentPrice(ctx, "tstusd")
require.Nil(t, err)
expCurPrice := sdk.MustNewDecFromStr("0.34")
require.Truef(
t,
price.Price.Equal(expCurPrice),
"expected current price to equal %v, actual %v",
expCurPrice, price.Price,
)
// Even number of oracles
_, err = keeper.SetPrice(
ctx, addrs[4], "tstusd",
sdk.MustNewDecFromStr("0.36"),
time.Now().Add(time.Hour*1))
require.NoError(t, err)
err = keeper.SetCurrentPrices(ctx, "tstusd")
require.NoError(t, err)
price, err = keeper.GetCurrentPrice(ctx, "tstusd")
require.Nil(t, err)
exp := sdk.MustNewDecFromStr("0.345")
require.Truef(t, price.Price.Equal(exp),
"current price %s should be %s",
price.Price.String(),
exp.String(),
)
prices := keeper.GetCurrentPrices(ctx)
require.Equal(t, 1, len(prices))
require.Equal(t, price, prices[0])
}
func TestKeeper_ExpiredSetCurrentPrices(t *testing.T) {
_, addrs := app.GeneratePrivKeyAddressPairs(5)
tApp := app.NewTestApp()
ctx := tApp.NewContext(true, tmprototypes.Header{}).
WithBlockTime(time.Now().UTC())
keeper := tApp.GetPriceFeedKeeper()
mp := types.Params{
Markets: []types.Market{
{MarketID: "tstusd", BaseAsset: "tst", QuoteAsset: "usd", Oracles: []sdk.AccAddress{}, Active: true},
},
}
keeper.SetParams(ctx, mp)
_, err := keeper.SetPrice(
ctx, addrs[0], "tstusd",
sdk.MustNewDecFromStr("0.33"),
time.Now().Add(time.Hour*1))
require.NoError(t, err)
_, err = keeper.SetPrice(
ctx, addrs[1], "tstusd",
sdk.MustNewDecFromStr("0.35"),
time.Now().Add(time.Hour*1))
require.NoError(t, err)
_, err = keeper.SetPrice(
ctx, addrs[2], "tstusd",
sdk.MustNewDecFromStr("0.34"),
time.Now().Add(time.Hour*1))
require.NoError(t, err)
// Update block time such that all prices expire
ctx = ctx.WithBlockTime(time.Now().UTC().Add(time.Hour * 2))
err = keeper.SetCurrentPrices(ctx, "tstusd")
require.ErrorIs(t, types.ErrNoValidPrice, err, "there should be no valid prices to be set")
_, err = keeper.GetCurrentPrice(ctx, "tstusd")
require.ErrorIs(t, types.ErrNoValidPrice, err, "current prices should be invalid")
}
func TestKeeper_SetCurrentPricesForAllMarkets_PriceUpdate(t *testing.T) {
testutil.SetCurrentPrices_PriceCalculations(t, func(ctx sdk.Context, keeper keeper.Keeper) {
keeper.SetCurrentPricesForAllMarkets(ctx)
})
}
func TestKeeper_SetCurrentPricesForAllMarkets_EventEmission(t *testing.T) {
testutil.SetCurrentPrices_EventEmission(t, func(ctx sdk.Context, keeper keeper.Keeper) {
keeper.SetCurrentPricesForAllMarkets(ctx)
})
}
func TestKeeper_SetCurrentPrices_MatchesAllMarketsBehavior(t *testing.T) {
testFunc := func(ctx sdk.Context, k keeper.Keeper) {
for _, market := range k.GetMarkets(ctx) {
if !market.Active {
continue
}
err := k.SetCurrentPrices(ctx, market.MarketID)
if err != nil && !errors.Is(err, types.ErrNoValidPrice) {
panic(err)
}
}
}
testutil.SetCurrentPrices_PriceCalculations(t, testFunc)
testutil.SetCurrentPrices_EventEmission(t, testFunc)
}