Kevin Davis
e913dc2ff0
Fix misleading comments from audit ( #592 )
...
* fix misleading or incorrect comments
* fix unnecessary variable declaration
* fix punctuation
2020-06-17 14:40:44 -04:00
Nick DeLuca
dda84c79ab
Add CLI Command to Query Kavadist Balance ( #590 )
...
* add command to view balance of kavadist module account
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-17 09:04:16 -04:00
Federico Kunze
bfb9f7e20a
cleanup begin/end block ( #553 )
...
* cleanup begin/end block
* update cdp BeginBlocker
* update dist mint
* fix tests
* typo
* add comment on CloseExpiredAuctions
* fix tests
2020-06-17 05:09:44 -04:00
Nick DeLuca
f0e73e4aa8
Refactor CreateAuctionsFromDeposit ( #589 )
...
* refactor CreateAuctionsFromDeposit to complete exhibits 7 & 8 by
removing auction slices and simplify usage of largest remainder method
2020-06-16 11:02:47 -04:00
Kevin Davis
db2b237e1d
[R4R] Restore supply endpoints ( #586 )
...
* feat: restore supply endpoints
* use complete circulating supply schedule
* standardize query path
2020-06-15 12:01:58 -04:00
Denali Marsh
3784b4971b
update bep3 docs for mainnet ( #587 )
...
* update bep3 docs for mainnet
* update make link-check
2020-06-15 04:37:28 -04:00
Kevin Davis
2eb6036f42
[R4R] Add client for kavadist module ( #584 )
...
* feat: add params query for kavadist
2020-06-12 15:45:07 -04:00
Nick DeLuca
3e63356c58
Cache redundant calculation in cdp RepayPrinciple ( #569 )
...
* fix exhibit 29 and remove redundant calcuation
* use better naming (totalPrincipal instead of totalDebt) and add comment
for future maintainers
2020-06-11 16:14:47 -04:00
Nick DeLuca
890411b685
fix exhibit 48 - error message should match if statement ( #580 )
2020-06-11 14:33:36 -05:00
Nick DeLuca
25abdd10b5
Remove some redunancy in RepayPrinciple ( #577 )
...
* fix exhibit 30 - remove redunant conversions in adding principle to fee
amount, and store debt denom in local var to avoid calling getter
several times
* add deleted comment back
2020-06-11 14:32:39 -05:00
Nick DeLuca
5ba2706d56
Optimize calculation in savings distribution ( #573 )
...
* fix exhibit 33 by storing remaining surplus
* simplify with sdk.MinInt - if statement logic & assignment is just
taking the minimum
2020-06-11 14:25:32 -05:00
Nick DeLuca
7ae76b8440
Auctions Clean Up - Fixes redenancy and legibility ( #576 )
...
* resolve exhibit 41 - move redundant assignment into if block and only
assign if value is false. No need to assign true to already true value.
* fix exhibit 43 - use existing auctionID variable instead of GetID
* use improved name for auction type in case statemnt
* rename a to auction in PlaceBidSurplus for legibility (part of exhibit 44)
* rename a to auctions in PlaceForwardBidCollateral (part of exhibit 44)
* rename a to auction in PlaceReverseBigCollateral for legibility (part of exhibit 44)
* rename a to auction in PlaceBidDebt for legibility (part of exhibit 44)
* renmae rest of a to auction variables for legibility and resolve exhibit
44
* one missed rename and a typo fix
2020-06-11 14:23:58 -05:00
Nick DeLuca
2a446fe530
fix misleading logging ( #572 )
2020-06-10 12:10:55 -04:00
Nick DeLuca
3f043b90ac
Update GetTotalSurplus and GetTotalDebt to be consistent ( #567 )
...
* update GetTotalSurplus and GetTotalDebt code blocks to be consistent and
resolve feedback in exhibit 13
* spelling fix
* remove uneeded temp variables
* address PR feedback - use suite.Require() instead of default assertions
2020-06-10 10:18:13 -04:00
Nick DeLuca
44467569af
Fix Ineffectual if statements ( #568 )
...
* fix exhibits 19,20,28,32 ineffectual if statements
* Apply suggestions from code review
* Apply suggestions from code review
* Update x/cdp/keeper/cdp.go
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-06-09 07:07:58 -04:00
Denali Marsh
978efbcc49
Fix bep3 sims determinism ( #555 )
...
* fix bep3 sims
* remove newline
2020-06-05 14:24:08 -04:00
Federico Kunze
b2a4369d4e
ValidatorVestingAccount validation ( #552 )
2020-06-05 08:59:16 -04:00
Kevin Davis
5723001390
fix: populate collateral denoms once ( #551 )
2020-06-05 08:41:13 -04:00
Denali Marsh
a44068d08d
use collateral params from cdp state ( #550 )
2020-06-04 19:14:40 -07:00
Denali Marsh
ba3b353ee9
[R4R] add bep3 module param to committee ( #547 )
...
* update committee test
* update committee params
* update default deputy address to expected mainnet address
* spelling in comment
* fix bep3 sim values to 1
* bep3 sims:generate 32 length random number
2020-06-04 18:27:54 -07:00
Denali Marsh
09a75bd7c6
[R4R] optional bep3 config params ( #546 )
...
* add minAmount, maxAmount
* update kava-3 params for compile
* fix migration script
* update to mainnet params
* remove height span validation for incoming swaps
* update to sdk.Int, set lock to 220
* update lock range to [220, 270]
* update bep3 module docs
* update MsgClaim's ValidateBasic
* update test comments
2020-06-04 16:03:14 -07:00
Kevin Davis
c049aad495
Minor audit fixes ( #540 )
...
* use mod and quo to calculate how many auctions to start
* check both return values in getDenomPrefix
* split auctions using weighted buckets
2020-06-04 08:58:39 -04:00
Kevin Davis
aebb3093ff
fix: use sdk.Int when loading augmented cdp ( #539 )
2020-06-03 18:36:58 -04:00
Ruaridh
4a8b5696cb
v0.8 Migration Scripts ( #518 )
...
* initial sketch
* add module migrations
* add migrations for all accout types
* test account migration
* add tendermint migration and migrate cmd
* remove need for errors pkg dependency
* add bech32 decoding fork
* add suggested params and cmd to write them
* add basic upgrade instructions
* fix tests
* address some migration todos
* tidy contrib folder
* finalize params values
* align cdp init genesis with other modules
* add tendermint and distribution test
add custom distribution migration to patch bug
* add staking migration test
* add slashing, evidence tests, refactor auth tests
* add full migration test
* remove go-amino dependency from go.mod
also tidy up unused indirect dependencies
* address remaining TODOs
* remove commented out code from legacy types
* add spot/liquidation markets ids to kava-3 params
* Apply suggestions from code review
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address code review suggestions
* add validate genesis to migrate test
* refactor add params func
* remove commented out code from old types
* fix add params
* add deputy address
* add tests using exported kava-2 state
* incorporate new cdp params from master
* update params from review
Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
* add deputy account
* add committee permissions for new params
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-06-03 15:35:00 -04:00
Denali Marsh
2d7f5c4080
[R4R] Better docs ( #541 )
...
* update sidebar order
* update event backticks
* fix broken links
* fix spelling
2020-06-03 14:54:31 -04:00
Denali Marsh
706207c60f
add backticks to params in spec ( #538 )
2020-06-02 10:49:29 -04:00
Kevin Davis
5336ccc0c0
Add surplus and debt auction lot params ( #531 )
...
* wip: add lot size param for surplus and debt auctions
* update tests with new params
* update spec
* address review comments
2020-05-31 09:59:40 -04:00
Denali Marsh
2ea06e4c80
[R4R] Basic docs tidying ( #534 )
...
* fix bep3 spec title, cdp collateral params
* display mod readme first
* fix link test
* update license year
2020-05-29 15:53:57 -07:00
Alexander Bezobchuk
90681abcc9
Merge PR #532 : Fix expiry parsing
2020-05-29 16:07:34 -04:00
Kevin Davis
eb3cb55fd0
Add incentive queries ( #528 )
...
* add incentive queries
* fix: add query route for claim periods
* address review comments
2020-05-28 10:57:22 -04:00
Federico Kunze
d130734c2e
x/incentive: genesis validation ( #519 )
...
* x/incentive: genesis validation
* validation funcs for arrays
* tests
* genesis tests
* rewards tests
* address @alexanderbez comments
* fix genesis incentive simulation
2020-05-28 10:26:08 -04:00
Denali Marsh
b2edeb8549
[R4R] Add flags to auction queries ( #522 )
...
* cli auction query flags
* update bep3 filter method name
* rest auction query flags
* add constants for auction type, phase
* fix test
* revisions
2020-05-24 19:27:11 -07:00
Alexander Bezobchuk
e7ceada952
REST Client Cleanup & Validation ( #523 )
...
* cleanup & from validation
* Add ValidateBasic calls
* Update x/incentive tx requests
* Address comments
2020-05-24 14:29:48 -04:00
Kevin Davis
aa54473309
fix struct tag ( #525 )
2020-05-24 09:46:22 -04:00
Kevin Davis
ade6edb918
[R4R] Add liquidation pricefeed ( #524 )
...
* add parameter for liquidation pricefeed
2020-05-24 09:42:46 -04:00
Federico Kunze
e3ce6a7c9f
x/auction: types validation ( #500 )
...
x/auction: types validation
2020-05-21 10:25:47 -04:00
Denali Marsh
67b89c2b9c
[R4R] Blacklist module accounts ( #517 )
...
* implement module account blacklist
* update cdp getModuleAccountCoins method
2020-05-21 00:50:12 -04:00
Kevin Davis
c556bd8c6c
fix: remove vesting client ( #516 )
2020-05-21 00:49:42 -04:00
Federico Kunze
ad7c08cfc3
x/pricefeed: GenesisState validation ( #514 )
...
* x/pricefeed: GenesisState validation
2020-05-21 00:49:27 -04:00
Denali Marsh
00508b61fe
Change !GTE to LT ( #512 )
2020-05-15 15:43:52 -07:00
Ruaridh
c28bc03248
Committtee audit revisions ( #510 )
...
* comments from review
Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch>
Co-authored-by: jmahess <maheswaran@google.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
* add vote methods
* add draft new param change permission
* add and update tests
* rename ParamChangePermission
* account for perms becoming invalid at a later time
* add debtParam to permission
* add bep3 AssetParam to permissions
* add pricefeed Markets to permission
* add upgrade permission
* move proposal passing to the begin blocker
* fix iteration bug
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
* address todos and audit comments
* add proposal examples
* refactor handler to be easier to read
* address review comments
* update comments
Co-authored-by: Kevin Davis <kjydavis3@gmail.com>
Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch>
Co-authored-by: jmahess <maheswaran@google.com>
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
2020-05-15 15:25:49 -04:00
Federico Kunze
5069aebda7
minor fix
2020-05-15 12:49:54 -04:00
Federico Kunze
6a07def455
remove test case
2020-05-15 12:43:52 -04:00
Denali Marsh
dd1d248be2
[R4R] Add BnbDeputyFixedFee param to BEP3 module ( #511 )
...
* generate length 32 random bytes
* fix test
* implement BnbDeputyFixedFee param
* clean up for PR
* update deputy address
* remove impossible check
* move comment
2020-05-13 16:39:29 -07:00
Denali Marsh
fa8ae9647a
[R4R] Update secure RNG to generate bytes directly ( #509 )
...
* generate length 32 random bytes
* fix test
2020-05-13 16:38:34 -07:00
Federico Kunze
9932169a67
sim fixes
2020-05-13 12:05:55 -04:00
Kevin Davis
1099dfbd7d
CDP revisions ( #508 )
...
* address review comments
* add kavadist to modaccount check
* cdp and deposit validation in genesis
* cleanup genesis validation
* add validation test for types
* don't error on augmented cdp loading
* simplify collateral auction logic
2020-05-13 10:19:19 -04:00
Federico Kunze
907e93b7a8
fix conflicts
2020-05-13 09:38:38 -04:00
Federico Kunze
6dedc1520a
x/auction: audit revisions ( #497 )
...
Auction audit revisions
2020-05-13 09:31:36 -04:00
Federico Kunze
1a46b3fa2b
fix tests
2020-05-13 09:24:17 -04:00
