Commit Graph

418 Commits

Author SHA1 Message Date
Ruaridh
ed57dd6ff1
Auction rest endpoints bugfix (#363)
* remove parameter brackets

* remove more param brackets
2020-02-04 12:56:10 -05:00
Ruaridh
bbc5d3b7a0
Auction rest fixes (#361)
* auction query fixes

* minor formating tweaks

* add phase info to debt & surplus auctions

* add base auction struct tags

* use module name in querier paths

* update rest tx endoint to use http body

* improve invalid coins error messages

* add rest examples

* align starting auction ID with gov and cdp

* fix cdp test broken by auction ID change

* fix all tests broken by ID change
2020-02-03 10:54:00 -05:00
Kevin Davis
31e185c632
[R4R] cdp rest fixes (#360)
* fix: use correct path for cdp queries

* fix: avoid params being confused for cdp denom

* fix: use consistent terminology

* fix: struct tag mismatch for repayment

* fix: use plural when querying multiple cdps

* fix: use correct type for query by ratio

* wip: refactor cdp query paths

* wip: routing queries

* fix: route prefixes

* wip: address review comments

* Update x/cdp/client/rest/query.go

Co-Authored-By: Ruaridh <rhuairahrighairidh@users.noreply.github.com>

* use post instead of put

Co-authored-by: Ruaridh <rhuairahrighairidh@users.noreply.github.com>
2020-02-03 10:41:28 -05:00
Denali Marsh
4599caca07
R4R: update pricefeed module rest endpoints (#359)
* query get price implemented - /pricefeed/price/xrp:usd

* query rawprices implemented - /pricefeed/rawprices/xrp:usd

* refactored to QueryWithMarketIDParams, added rest logic for QueryOracles

* new query get oracles implemented for cli and rest - /pricefeed/oracles/xrp:usd

* tx postprice implemented - /pricefeed/postprice/{MsgPostPrice}

* updated contrib with post-price examples and added to README

* added cliCtx.WithHeight(height) and removed import comment
2020-02-02 11:06:33 -05:00
Ruaridh
183acfef62
auction query fixes (#354) 2020-02-01 10:49:36 -05:00
Kevin Davis
3b8b9ef9bc
fix: correct tx broadcasting post format (#356) 2020-02-01 10:49:12 -05:00
Kevin Davis
cd754a25d9
[R4R] Minor rest fixes (#355)
* feat: add swagger

* add version info for mainnet

* feat: update swagger

* fix: type in get params path

* feat: example for creating cdp

* feat: example broadcast signed tx

* feat: examples for depositing to cdp

* added README with example cdp create rest-server request (#358)

* fix: make link-check happy

Co-authored-by: Denali Marsh <denalimarsh@gmail.com>
2020-01-31 17:31:22 -05:00
Kevin Davis
4f8b144381
add version info for mainnet 2020-01-31 12:28:28 -05:00
Kevin Davis
bdff81b2a2
fix: avoid panic when closing cdp via repayment (#353) 2020-01-30 18:50:42 -05:00
Denali Marsh
3c8209cbcc
fix panic(err) if posted_prices=[] in genesis file (#352) 2020-01-29 16:12:47 -08:00
Kevin Davis
55f0f8d980
Display auction type and phase when querying auctions (#345)
* feat: differentiate auction types when queried

* feat: display auction type

* feat: add phase of collateral auctions

* fix: set reverse phase directly

* feat: revert base auction, use querying specifc structs

* fix: pass auction as interface to handlers

* set reverse phase on max bid (#348)

* Revert "set reverse phase on max bid (#348)" (#351)

This reverts commit 4b855250d529a4cbecb16d9d32b25ffeaffa3a68.

* fix: missing return

* fix: include collateral auction type

* fix: always include phase field for queries

Co-authored-by: Denali Marsh <denalimarsh@gmail.com>
2020-01-29 08:42:03 -06:00
Kevin Davis
84fa0ef51d
fix: apply penalty to partial deposits (#350) 2020-01-28 14:38:38 -06:00
Kevin Davis
024001888c
Add query for cdp deposits (#346)
* feat: query cdp deposits

* feat: test querying deposits

* fix: update comment

* fix: use single word command
2020-01-28 14:08:17 -06:00
Denali Marsh
bf64a5c02c
R4R: add collateral value, collateralization ratio to CDP querier (#347)
* AugmentedCDP type, codec registration, querier update

* added unique error for augmented cdp loading

* added AugmentedCDPs type for cdps query res

* query results for cdps (by denom) & cdps-by-ratio (by denom & ratio)

* status: converting collateral value into debt coin denom

* collateral value denominated in debt coin

* query cdps-by-ratio now searches by collateralization ratio instead of absolute ratio

* updated alias, code comments

* updated querier tests

* support multiple principal coins and their associated fees

* collateralization ratio calculations on updated fees

* include calculated fees in total debt calculation
2020-01-28 09:47:08 -08:00
Denali Marsh
075a3089ce
R4R: add events to pricefeed module (#343)
* added events, attributes to pricefeed msgs and core functionality

* removed added space

* conditionally emit market_price_updated if price has changed

* updated expiry to Unix format
2020-01-27 10:07:42 -08:00
Denali Marsh
99be9dd8ab [WIP] example proposal.json files for param changes (#331)
* proposal examples, copy of cdptestnet genesis

* co-located genesis files with their respective proposals in contrib

* added genesis file for updatedebtlimit

* Removed legacy genesis example

* added sample genesis files as starting states of auction tests

* auction proposal json files (untested)

* max auction duration and bid duration tested

* requested changes
2020-01-24 16:44:13 -05:00
Ruaridh
07c1a8c126 fix typo (#332) 2020-01-24 13:31:33 -05:00
Ruaridh
d24f364ed3
add weighted address tags (#336) 2020-01-24 11:39:52 +00:00
Ruaridh
33ad221e5f
Fix gov denom typo (#333) 2020-01-24 11:39:09 +00:00
Ruaridh
d018aaebcf fix typo (#330) 2020-01-23 17:41:59 -05:00
Kevin Davis
535094df96
Fix: Avoid panics when adding cdp collaterals via governance (#329)
* fix: remove unnecessary accumulator key

* fix: correct test comment

* fix: avoid panic when cdp collateral type added
2020-01-23 15:41:45 -05:00
Ruaridh
e11b298c28 Add CDP Spec (#328)
* add overview and basic structure

* add state and params

* add basic messages

* add state transitions

* add begin block state transitions

* add missing titles

* add concepts

* add events

* update state and concepts

* update for liquidator changes

* update events

* mention module accounts

* update begin block

* update params

* update page numbering

* add fee descriptions

* add broken link linter

* add broken link linter to CI

* move link check to end of CI

* update typo

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* address review comments

* Update x/cdp/spec/06_params.md

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* Update x/cdp/spec/README.md

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* Update x/cdp/spec/README.md

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-01-23 14:09:36 -05:00
Kevin Davis
58deb49e55
Fix withdraw panic (#315)
* fix: remove redundant debt limit param

* wip: test pricefeed genesis

* fix: pricefeed querier

* fix: comments, naming

* fix: query path

* fix: store methods

* fix: query methods

* feat: Liquidation Penalty

* feat: enforce debt floor on repayment

* fix: don't panic if withdrawing full amount

* fix: remove debt from liquidation penalty
2020-01-22 16:56:30 +00:00
Kevin Davis
22dc15f757
Apply debt floor to repayments (#314)
* fix: remove redundant debt limit param

* wip: test pricefeed genesis

* fix: pricefeed querier

* fix: comments, naming

* fix: query path

* fix: store methods

* fix: query methods

* feat: Liquidation Penalty

* feat: enforce debt floor on repayment

* address review comments

* fix: remove debt from liquidation penalty

* test: remove payment > balance check

* feat: handle overpayment

* fix: avoid negative coins error for overpayments
2020-01-22 16:50:27 +00:00
Denali Marsh
ab72433db0
add json/yaml to msgs (#323)
* added json/yaml to MsgPostPrice, MsgPlaceBid

* Added sdk.Msg to ensure Msg interface compliance at compile time
2020-01-21 13:40:04 -08:00
Ruaridh
bab798f50d
fix: avoid panic if cdp debt > debt held by cdp account (#326)
Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-01-21 20:28:25 +00:00
Denali Marsh
f6a3567a66 removed unimplemented MsgTransferCDP (#325) 2020-01-21 18:24:33 +00:00
Kevin Davis
a74f63a8f2 Apply Liquidation Penalty (#313)
* fix: remove redundant debt limit param

* wip: test pricefeed genesis

* fix: pricefeed querier

* fix: comments, naming

* fix: query path

* fix: store methods

* fix: query methods

* feat: Liquidation Penalty

* fix: remove debt from liquidation penalty
2020-01-21 17:52:07 +00:00
Ruaridh
f01a3f46ee
Auction cli/rest fixes (#319)
* cleanup auction tx cli

* add querier for getting one auction

* missed querier fixes

* update querier tests

* add msg struct tags

* add auction rest endpoint and tidy

* add struct tags to auctions

* minor UX tweaks
2020-01-21 17:41:37 +00:00
Ruaridh
2be1a3196e
make bidding tests independent (#322) 2020-01-21 10:06:07 +00:00
Ruaridh
d887266c24
Run begin blocker (#321)
* add cdp begin blocker

* fix: use reasonable defaults for surplus/debt auctions

Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-01-20 19:28:30 +00:00
Ruaridh
1b577fcdbb
Merge pull request #317 from Kava-Labs/ro-tiny-pricefeed-fix
add missing return
2020-01-17 16:29:46 +01:00
rhuairahrighairigh
b879689052 add missing return 2020-01-17 16:17:48 +01:00
Denali Marsh
710a29980f R4R: add params query to pricefeed module (#311)
* fix: remove redundant debt limit param

* wip: test pricefeed genesis

* fix: pricefeed querier

* fix: comments, naming

* fix: query path

* fix: store methods

* fix: query methods

* add params query to pricefeed module

* minor formatting updates, removed commented out legacy code, etc.

Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-01-17 13:55:17 +01:00
Kevin Davis
d04aad5cc9
Pricefeed fixes (#308)
* fix: remove redundant debt limit param

* wip: test pricefeed genesis

* fix: pricefeed querier

* fix: comments, naming

* fix: query path

* fix: store methods

* fix: query methods

* fix: standardize genesis validation
2020-01-17 13:29:19 +01:00
Kevin Davis
dca59447aa
fix: remove redundant debt limit param (#312) 2020-01-17 13:24:43 +01:00
Denali Marsh
d286f53053
R4R: cli auction clean up (#310)
* kvcli q auction params

* reset go.sum

* Updated QueryGetAuctionsCmd naming to match conventions

* clean up: tx auctions placebid

* requested changes
2020-01-16 18:52:29 +01:00
Ruaridh
c5043ffabe add stability fee validation (#307) 2020-01-16 16:21:38 +01:00
Ruaridh
2d9820b3d1 cdp cli clean up (#305)
* clean up querier cmds #304 #298 #296

* #299 address cli ux issues

* fix typo

* edit help message
2020-01-16 16:20:12 +01:00
Kevin Davis
a9c92439c6
Correct json field tags in pricefeed, auction (#301)
* fix: genesis param json tags

* chore: linting

* fix: missing tags in collateral

* fix: genesis auctions tag
2020-01-16 16:17:57 +01:00
Kevin Davis
2193b19c1d fix: genesis auctions tag 2020-01-16 16:17:16 +01:00
Kevin Davis
69436f447f fix: missing tags in collateral 2020-01-16 14:30:59 +01:00
Kevin Davis
407361313e chore: linting 2020-01-16 12:15:27 +01:00
Kevin Davis
6bf1a4ce5b fix: genesis param json tags 2020-01-16 12:15:18 +01:00
Kevin Davis
9b1bf55be7
R4R: Move liquidator functions to cdp module (#280)
* wip: tpyes and keeper methods

* wip: iterators

* wip: types and keeper methods

* wip: add msgs

* wip: client methods

* wip: rebase develop

* wip: types tests

* wip: keeper tests, small fixes

* wip: add cdp tests

* wip: deposit tests

* wip: keeper tests

* wip: tests and module methods

* feat: error when fetching expired price

* feat: conversion factor for external assets

* feat: debt floor for new cdps

* feat: save deposits on export genesis

* feat: ensure messages implement msg

* feat: index deposits by status

* fix: stray comment

* wip: address review comments

* address review comments

* wip: move liquidation to cdp module

* wip: handle liquidations directly

* wip: use new auction interface

* feat: auction collateral in cdp begin block

* feat: update param validation

* feat: surplus and debt auctions

* address review comments

* address review comments

* fix: auction multiple deposits

* clean up netting function
2020-01-15 15:19:33 +01:00
Denali Marsh
ba80b508ab [R4R] Custom sdk.Error types for the auction module (#285)
* Custom sdk.Error types for the auction module

* Requested changes: naming conventions, error message text
2020-01-15 11:39:55 +01:00
Kevin Davis
8128a680cc
Ro address auction todos (#284)
* make auctions not expire without bids

* add events

* improve genesis state validation

* add genesis tests

* Keeper auctions test, types auctions test, keeper bidding test

* Resolved TODOs, added querier test

* Removed 'import x/liquidator' from keeper_test package for circleci

* Fixes for lack of liquidator module account in tests

* update comment

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* add more events attributes

* feat: add back bidding on closed auction test

* feat: test failed debt/collateral auctions

Co-authored-by: Ruaridh <rhuairahrighairidh@users.noreply.github.com>
Co-authored-by: Denali Marsh <denalimarsh@gmail.com>
2020-01-14 16:04:47 +01:00
Ruaridh
22e168d06a Various Auction TODOs (#281)
* make auctions not expire without bids

* add events

* improve genesis state validation

* add genesis tests

* update comment

Co-Authored-By: Kevin Davis <karzak@users.noreply.github.com>

* add more events attributes

Co-authored-by: Kevin Davis <karzak@users.noreply.github.com>
2020-01-14 15:00:37 +01:00
rhuairahrighairigh
aa6dfab6fd Merge branch 'ro-add-debt-tracking-to-auctions' 2020-01-14 12:10:39 +01:00
Kevin Davis
d849d690e5
R4R: CDP types and methods (#275)
* wip: tpyes and keeper methods

* wip: iterators

* wip: types and keeper methods

* wip: add msgs

* wip: client methods

* wip: rebase develop

* wip: types tests

* wip: keeper tests, small fixes

* wip: add cdp tests

* wip: deposit tests

* wip: keeper tests

* wip: tests and module methods

* feat: error when fetching expired price

* feat: conversion factor for external assets

* feat: debt floor for new cdps

* feat: save deposits on export genesis

* feat: ensure messages implement msg

* feat: index deposits by status

* fix: stray comment

* wip: address review comments

* address review comments
2020-01-12 16:35:34 +01:00