From 7847f3ee7ba1ba14327d00f372682828827d1269 Mon Sep 17 00:00:00 2001 From: Nick DeLuca Date: Sat, 8 Oct 2022 19:37:36 -0700 Subject: [PATCH] Tally Handler Fixes (#1342) * reassign after addition since values are not modified in place * fix incorrect logic; add bkava when there is no error --- app/tally_handler.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/tally_handler.go b/app/tally_handler.go index 4e68e73e..b24f230a 100644 --- a/app/tally_handler.go +++ b/app/tally_handler.go @@ -193,13 +193,13 @@ func (bkavaMap bkavaByDenom) add(coin sdk.Coin) { if !found { bkavaMap[coin.Denom] = sdk.ZeroInt() } - bkavaMap[coin.Denom].Add(coin.Amount) + bkavaMap[coin.Denom] = bkavaMap[coin.Denom].Add(coin.Amount) } func (bkavaMap bkavaByDenom) toCoins() sdk.Coins { coins := sdk.Coins{} for denom, amt := range bkavaMap { - coins.Add(sdk.NewCoin(denom, amt)) + coins = coins.Add(sdk.NewCoin(denom, amt)) } return coins.Sort() } @@ -245,7 +245,7 @@ func (th TallyHandler) addBkavaFromEarn(ctx sdk.Context, addr sdk.AccAddress, bk } for _, share := range shares { if th.lk.IsDerivativeDenom(ctx, share.Denom) { - if coin, err := th.ek.ConvertToAssets(ctx, share); err != nil { + if coin, err := th.ek.ConvertToAssets(ctx, share); err == nil { bkava.add(coin) } }