smeb_y/0g-chain
1
0
Fork 0
mirror of https://github.com/0glabs/0g-chain.git synced 2024-12-24 23:35:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[R4R]: Avoid divide by zero when price is very small (#441)

Browse Source 
* fix: avoid divide by zero when price is very small

* fix: typo
This commit is contained in:
Kevin Davis 2020-04-16 07:43:44 -04:00 committed by GitHub
parent 4cde3ba577
commit 783247851d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
x/cdp/keeper/fees.go
View File

@ -41,9 +41,12 @@ func (k Keeper) UpdateFeesForRiskyCdps(ctx sdk.Context, collateralDenom string,
} }
liquidationRatio := k.getLiquidationRatio(ctx, collateralDenom) liquidationRatio := k.getLiquidationRatio(ctx, collateralDenom)
priceDivLiqRatio := price.Price.Quo(liquidationRatio)
if priceDivLiqRatio.IsZero() {
priceDivLiqRatio = sdk.SmallestDec()
}
// NOTE - we have a fixed cutoff at 110% - this may or may not be changed in the future // NOTE - we have a fixed cutoff at 110% - this may or may not be changed in the future
normalizedRatio := sdk.OneDec().Quo(price.Price.Quo(liquidationRatio)).Mul(sdk.MustNewDecFromStr("1.1")) normalizedRatio := sdk.OneDec().Quo(priceDivLiqRatio).Mul(sdk.MustNewDecFromStr("1.1"))
// now iterate over all the cdps based on collateral ratio // now iterate over all the cdps based on collateral ratio
k.IterateCdpsByCollateralRatio(ctx, collateralDenom, normalizedRatio, func(cdp types.CDP) bool { k.IterateCdpsByCollateralRatio(ctx, collateralDenom, normalizedRatio, func(cdp types.CDP) bool {

6
x/cdp/keeper/seize.go
View File

@ -109,10 +109,14 @@ func (k Keeper) LiquidateCdps(ctx sdk.Context, marketID string, denom string, li
if err != nil { if err != nil {
return err return err
} }
priceDivLiqRatio := price.Price.Quo(liquidationRatio)
if priceDivLiqRatio.IsZero() {
priceDivLiqRatio = sdk.SmallestDec()
}
// price = $0.5 // price = $0.5
// liquidation ratio = 1.5 // liquidation ratio = 1.5
// normalizedRatio = (1/(0.5/1.5)) = 3 // normalizedRatio = (1/(0.5/1.5)) = 3
normalizedRatio := sdk.OneDec().Quo(price.Price.Quo(liquidationRatio)) normalizedRatio := sdk.OneDec().Quo(priceDivLiqRatio)
cdpsToLiquidate := k.GetAllCdpsByDenomAndRatio(ctx, denom, normalizedRatio) cdpsToLiquidate := k.GetAllCdpsByDenomAndRatio(ctx, denom, normalizedRatio)
for _, c := range cdpsToLiquidate { for _, c := range cdpsToLiquidate {
err := k.SeizeCollateral(ctx, c) err := k.SeizeCollateral(ctx, c)