auction tests

This commit is contained in:
Federico Kunze 2020-05-12 16:32:18 -04:00
parent e3aad2306b
commit 71742d2eef
No known key found for this signature in database
GPG Key ID: 655F93A970080A30
2 changed files with 343 additions and 55 deletions

View File

@ -83,9 +83,6 @@ func (a BaseAuction) Validate() error {
if len(a.Bidder) != sdk.AddrLen { if len(a.Bidder) != sdk.AddrLen {
return fmt.Errorf("the expected bidder address length is %d, actual length is %d", sdk.AddrLen, len(a.Bidder)) return fmt.Errorf("the expected bidder address length is %d, actual length is %d", sdk.AddrLen, len(a.Bidder))
} }
if len(a.Bidder.Bytes()) != sdk.AddrLen {
return errors.New("auction bidder cannot be empty")
}
if !a.Bid.IsValid() { if !a.Bid.IsValid() {
return fmt.Errorf("invalid bid: %s", a.Bid) return fmt.Errorf("invalid bid: %s", a.Bid)
} }
@ -202,7 +199,8 @@ func NewDebtAuction(buyerModAccName string, bid sdk.Coin, initialLot sdk.Coin, e
Bid: bid, // amount that the buyer is buying - doesn't change over course of auction Bid: bid, // amount that the buyer is buying - doesn't change over course of auction
HasReceivedBids: false, // new auctions don't have any bids HasReceivedBids: false, // new auctions don't have any bids
EndTime: endTime, EndTime: endTime,
MaxEndTime: endTime}, MaxEndTime: endTime,
},
CorrespondingDebt: debt, CorrespondingDebt: debt,
} }
return auction return auction
@ -326,7 +324,7 @@ func (wa WeightedAddresses) Validate() error {
return fmt.Errorf("address %d cannot be empty", i) return fmt.Errorf("address %d cannot be empty", i)
} }
if len(wa.Addresses[i]) != sdk.AddrLen { if len(wa.Addresses[i]) != sdk.AddrLen {
return fmt.Errorf("address %d has an invalid length: expectd %d, got %d", i, sdk.AddrLen, len(wa.Addresses[i])) return fmt.Errorf("address %d has an invalid length: expected %d, got %d", i, sdk.AddrLen, len(wa.Addresses[i]))
} }
if wa.Weights[i].IsNegative() { if wa.Weights[i].IsNegative() {
return fmt.Errorf("weight %d contains a negative amount: %s", i, wa.Weights[i]) return fmt.Errorf("weight %d contains a negative amount: %s", i, wa.Weights[i])

View File

@ -20,11 +20,20 @@ const (
TestDebtAmount2 = 15 TestDebtAmount2 = 15
TestExtraEndTime = 10000 TestExtraEndTime = 10000
TestAuctionID = 9999123 TestAuctionID = 9999123
TestAccAddress1 = "kava1qcfdf69js922qrdr4yaww3ax7gjml6pd39p8lj" testAccAddress1 = "kava1qcfdf69js922qrdr4yaww3ax7gjml6pd39p8lj"
TestAccAddress2 = "kava1pdfav2cjhry9k79nu6r8kgknnjtq6a7rcr0qlr" testAccAddress2 = "kava1pdfav2cjhry9k79nu6r8kgknnjtq6a7rcr0qlr"
) )
func init() {
sdk.GetConfig().SetBech32PrefixForAccount("kava", "kava"+sdk.PrefixPublic)
}
func TestNewWeightedAddresses(t *testing.T) { func TestNewWeightedAddresses(t *testing.T) {
addr1, err := sdk.AccAddressFromBech32(testAccAddress1)
require.NoError(t, err)
addr2, err := sdk.AccAddressFromBech32(testAccAddress2)
require.NoError(t, err)
tests := []struct { tests := []struct {
name string name string
@ -34,69 +43,350 @@ func TestNewWeightedAddresses(t *testing.T) {
}{ }{
{ {
"normal", "normal",
[]sdk.AccAddress{ []sdk.AccAddress{addr1, addr2},
sdk.AccAddress([]byte(TestAccAddress1)), []sdk.Int{sdk.NewInt(6), sdk.NewInt(8)},
sdk.AccAddress([]byte(TestAccAddress2)),
},
[]sdk.Int{
sdk.NewInt(6),
sdk.NewInt(8),
},
true, true,
}, },
{
"empty address",
[]sdk.AccAddress{nil, nil},
[]sdk.Int{sdk.NewInt(6), sdk.NewInt(8)},
false,
},
{ {
"mismatched", "mismatched",
[]sdk.AccAddress{ []sdk.AccAddress{addr1, addr2},
sdk.AccAddress([]byte(TestAccAddress1)), []sdk.Int{sdk.NewInt(6)},
sdk.AccAddress([]byte(TestAccAddress2)),
},
[]sdk.Int{
sdk.NewInt(6),
},
false, false,
}, },
{ {
"negativeWeight", "negativeWeight",
[]sdk.AccAddress{ []sdk.AccAddress{addr1, addr2},
sdk.AccAddress([]byte(TestAccAddress1)), []sdk.Int{sdk.NewInt(6), sdk.NewInt(-8)},
sdk.AccAddress([]byte(TestAccAddress2)),
},
[]sdk.Int{
sdk.NewInt(6),
sdk.NewInt(-8),
},
false, false,
}, },
} }
// Run NewWeightedAdresses tests // Run NewWeightedAdresses tests
for _, tc := range tests { for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) { // Attempt to instantiate new WeightedAddresses
// Attempt to instantiate new WeightedAddresses weightedAddresses, err := NewWeightedAddresses(tc.addresses, tc.weights)
weightedAddresses, err := NewWeightedAddresses(tc.addresses, tc.weights)
if tc.expectpass { if tc.expectpass {
// Confirm there is no error require.NoError(t, err)
require.Nil(t, err) require.Equal(t, tc.addresses, weightedAddresses.Addresses)
require.Equal(t, tc.weights, weightedAddresses.Weights)
} else {
require.Error(t, err)
}
}
}
// Check addresses, weights func TestBaseAuctionValidate(t *testing.T) {
require.Equal(t, tc.addresses, weightedAddresses.Addresses) addr1, err := sdk.AccAddressFromBech32(testAccAddress1)
require.Equal(t, tc.weights, weightedAddresses.Weights) require.NoError(t, err)
} else {
// Confirm that there is an error
require.NotNil(t, err)
switch tc.name { now := time.Now()
case "mismatched":
require.Contains(t, err.Error(), "number of addresses doesn't match number of weights") tests := []struct {
case "negativeWeight": msg string
require.Contains(t, err.Error(), "weights contain a negative amount") auction BaseAuction
default: expPass bool
// Unexpected error state }{
t.Fail() {
} "valid auction",
} BaseAuction{
}) ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: now,
MaxEndTime: now,
HasReceivedBids: true,
},
true,
},
{
"0 id",
BaseAuction{ID: 0},
false,
},
{
"blank initiator",
BaseAuction{
ID: 1,
Initiator: "",
},
false,
},
{
"invalid lot",
BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: sdk.Coin{Denom: "DENOM", Amount: sdk.NewInt(1)},
},
false,
},
{
"empty bidder",
BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: nil,
},
false,
},
{
"invalid bidder",
BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1[:10],
},
false,
},
{
"invalid bid",
BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: sdk.Coin{Denom: "DENOM", Amount: sdk.NewInt(1)},
},
false,
},
{
"invalid end time",
BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: time.Unix(0, 0),
},
false,
},
{
"max end time > endtime",
BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: now.Add(time.Minute),
MaxEndTime: now,
},
false,
},
{
"zero bid with received bids",
BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 0),
EndTime: now,
MaxEndTime: now,
HasReceivedBids: true,
},
false,
},
{
"positive bid without receiving bids",
BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: now,
MaxEndTime: now,
HasReceivedBids: false,
},
false,
},
}
for _, tc := range tests {
err := tc.auction.Validate()
if tc.expPass {
require.NoError(t, err, tc.msg)
} else {
require.Error(t, err, tc.msg)
}
}
}
func TestDebtAuctionValidate(t *testing.T) {
addr1, err := sdk.AccAddressFromBech32(testAccAddress1)
require.NoError(t, err)
now := time.Now()
tests := []struct {
msg string
auction DebtAuction
expPass bool
}{
{
"valid auction",
DebtAuction{
BaseAuction: BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: now,
MaxEndTime: now,
HasReceivedBids: true,
},
CorrespondingDebt: c("kava", 1),
},
true,
},
{
"invalid corresponding debt",
DebtAuction{
BaseAuction: BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: now,
MaxEndTime: now,
HasReceivedBids: true,
},
CorrespondingDebt: sdk.Coin{Denom: "DENOM", Amount: sdk.NewInt(1)},
},
false,
},
}
for _, tc := range tests {
err := tc.auction.Validate()
if tc.expPass {
require.NoError(t, err, tc.msg)
} else {
require.Error(t, err, tc.msg)
}
}
}
func TestCollateralAuctionValidate(t *testing.T) {
addr1, err := sdk.AccAddressFromBech32(testAccAddress1)
require.NoError(t, err)
now := time.Now()
tests := []struct {
msg string
auction CollateralAuction
expPass bool
}{
{
"valid auction",
CollateralAuction{
BaseAuction: BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: now,
MaxEndTime: now,
HasReceivedBids: true,
},
CorrespondingDebt: c("kava", 1),
MaxBid: c("kava", 1),
LotReturns: WeightedAddresses{
Addresses: []sdk.AccAddress{addr1},
Weights: []sdk.Int{sdk.NewInt(1)},
},
},
true,
},
{
"invalid corresponding debt",
CollateralAuction{
BaseAuction: BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: now,
MaxEndTime: now,
HasReceivedBids: true,
},
CorrespondingDebt: sdk.Coin{Denom: "DENOM", Amount: sdk.NewInt(1)},
},
false,
},
{
"invalid max bid",
CollateralAuction{
BaseAuction: BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: now,
MaxEndTime: now,
HasReceivedBids: true,
},
CorrespondingDebt: c("kava", 1),
MaxBid: sdk.Coin{Denom: "DENOM", Amount: sdk.NewInt(1)},
},
false,
},
{
"invalid lot returns",
CollateralAuction{
BaseAuction: BaseAuction{
ID: 1,
Initiator: testAccAddress1,
Lot: c("kava", 1),
Bidder: addr1,
Bid: c("kava", 1),
EndTime: now,
MaxEndTime: now,
HasReceivedBids: true,
},
CorrespondingDebt: c("kava", 1),
MaxBid: c("kava", 1),
LotReturns: WeightedAddresses{
Addresses: []sdk.AccAddress{nil},
Weights: []sdk.Int{sdk.NewInt(1)},
},
},
false,
},
}
for _, tc := range tests {
err := tc.auction.Validate()
if tc.expPass {
require.NoError(t, err, tc.msg)
} else {
require.Error(t, err, tc.msg)
}
} }
} }
@ -163,8 +453,8 @@ func TestNewDebtAuction(t *testing.T) {
func TestNewCollateralAuction(t *testing.T) { func TestNewCollateralAuction(t *testing.T) {
// Set up WeightedAddresses // Set up WeightedAddresses
addresses := []sdk.AccAddress{ addresses := []sdk.AccAddress{
sdk.AccAddress([]byte(TestAccAddress1)), sdk.AccAddress([]byte(testAccAddress1)),
sdk.AccAddress([]byte(TestAccAddress2)), sdk.AccAddress([]byte(testAccAddress2)),
} }
weights := []sdk.Int{ weights := []sdk.Int{