From 6853e4fc9cf5f77a80cdfaa0f4d0c2f58e28a744 Mon Sep 17 00:00:00 2001 From: Robert Pirtle Date: Mon, 5 Jun 2023 13:26:02 -0700 Subject: [PATCH] cli!: rename evm-native asset conversion cli cmds (#1614) --- CHANGELOG.md | 5 +++++ x/evmutil/client/cli/tx.go | 24 ++++++++++++------------ 2 files changed, 17 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9d0c0d62..c0c84786 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -51,6 +51,10 @@ Ref: https://keepachangelog.com/en/1.0.0/ - (evmutil) [#1604] Renamed event types - `convert_erc20_to_coin` -> `convert_evm_erc20_to_coin` - `convert_coin_to_erc20` -> `convert_evm_erc20_from_coin` +- (evmutil) [#1614] Renamed CLI commands for converting an EVM-native asset to sdk.Coin + NOTE: no changes were made to existing Msg names (`MsgConvertCoinToERC20` & `MsgConvertERC20ToCoin`) + - `convert-erc20-to-coin` -> `convert-evm-erc20-to-coin` + - `convert-coin-to-erc20` -> `convert-evm-erc20-from-coin` ## [v0.23.0] @@ -253,6 +257,7 @@ the [changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.38.4/CHANGELOG.md). - [#257](https://github.com/Kava-Labs/kava/pulls/257) Include scripts to run large-scale simulations remotely using aws-batch +[#1614]: https://github.com/Kava-Labs/kava/pull/1614 [#1610]: https://github.com/Kava-Labs/kava/pull/1610 [#1609]: https://github.com/Kava-Labs/kava/pull/1609 [#1605]: https://github.com/Kava-Labs/kava/pull/1605 diff --git a/x/evmutil/client/cli/tx.go b/x/evmutil/client/cli/tx.go index 598e1494..22201af6 100644 --- a/x/evmutil/client/cli/tx.go +++ b/x/evmutil/client/cli/tx.go @@ -28,8 +28,8 @@ func GetTxCmd() *cobra.Command { } cmds := []*cobra.Command{ - getCmdMsgConvertCoinToERC20(), - getCmdConvertERC20ToCoin(), + getCmdConvertEvmERC20FromCoin(), + getCmdConvertEvmERC20ToCoin(), getCmdMsgConvertCosmosCoinToERC20(), getCmdMsgConvertCosmosCoinFromERC20(), } @@ -43,12 +43,12 @@ func GetTxCmd() *cobra.Command { return txCmd } -func getCmdMsgConvertCoinToERC20() *cobra.Command { +func getCmdConvertEvmERC20FromCoin() *cobra.Command { return &cobra.Command{ - Use: "convert-coin-to-erc20 [Kava EVM address] [coin]", - Short: "converts sdk.Coin to erc20 tokens on Kava eth co-chain", + Use: "convert-evm-erc20-from-coin [Kava EVM address] [coin]", + Short: "EVM-native asset: converts a coin on Cosmos co-chain to an ERC20 on EVM co-chain", Example: fmt.Sprintf( - `%s tx %s convert-coin-to-erc20 0x7Bbf300890857b8c241b219C6a489431669b3aFA 500000000erc20/usdc --from --gas 2000000`, + `%s tx %s convert-evm-erc20-from-coin 0x7Bbf300890857b8c241b219C6a489431669b3aFA 500000000erc20/usdc --from --gas 2000000`, version.AppName, types.ModuleName, ), Args: cobra.ExactArgs(2), @@ -79,12 +79,12 @@ func getCmdMsgConvertCoinToERC20() *cobra.Command { } } -func getCmdConvertERC20ToCoin() *cobra.Command { +func getCmdConvertEvmERC20ToCoin() *cobra.Command { return &cobra.Command{ - Use: "convert-erc20-to-coin [Kava receiver address] [Kava ERC20 address] [amount]", - Short: "burns ERC20 tokens on Kava EVM co-chain and unlocks on Ethereum", + Use: "convert-evm-erc20-to-coin [Kava receiver address] [Kava ERC20 address] [amount]", + Short: "EVM-native asset: converts an ERC20 on EVM co-chain to a coin on Cosmos co-chain", Example: fmt.Sprintf(` -%[1]s tx %[2]s convert-erc20-to-coin kava10wlnqzyss4accfqmyxwx5jy5x9nfkwh6qm7n4t 0xeA7100edA2f805356291B0E55DaD448599a72C6d 1000000000000000 --from --gas 1000000 +%[1]s tx %[2]s convert-evm-erc20-to-coin kava10wlnqzyss4accfqmyxwx5jy5x9nfkwh6qm7n4t 0xeA7100edA2f805356291B0E55DaD448599a72C6d 1000000000000000 --from --gas 1000000 `, version.AppName, types.ModuleName, ), Args: cobra.ExactArgs(3), @@ -127,7 +127,7 @@ func getCmdConvertERC20ToCoin() *cobra.Command { func getCmdMsgConvertCosmosCoinToERC20() *cobra.Command { return &cobra.Command{ Use: "convert-cosmos-coin-to-erc20 [receiver_0x_address] [amount] [flags]", - Short: "converts asset native to Cosmos Co-chain to an ERC20 on the EVM Co-chain", + Short: "Cosmos-native asset: converts a coin on Cosmos co-chain to an ERC20 on EVM co-chain", Example: fmt.Sprintf( `Convert 500 ATOM and send ERC20 to 0x03db6b11F47d074a532b9eb8a98aB7AdA5845087: %s tx %s convert-cosmos-coin-to-erc20 0x03db6b11F47d074a532b9eb8a98aB7AdA5845087 500000000ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2 --from --gas 2000000`, @@ -164,7 +164,7 @@ func getCmdMsgConvertCosmosCoinToERC20() *cobra.Command { func getCmdMsgConvertCosmosCoinFromERC20() *cobra.Command { return &cobra.Command{ Use: "convert-cosmos-coin-from-erc20 [receiver_kava_address] [amount] [flags]", - Short: "converts asset native to Cosmos Co-chain back from an ERC20 on the EVM co-chain", + Short: "Cosmos-native asset: converts an ERC20 on EVM co-chain back to a coin on Cosmos co-chain", Example: fmt.Sprintf( `Convert ERC20 representation of 500 ATOM back to a Cosmos coin, sending to kava1q0dkky0505r555etn6u2nz4h4kjcg5y8dg863a: %s tx %s convert-cosmos-coin-from-erc20 kava1q0dkky0505r555etn6u2nz4h4kjcg5y8dg863a 500000000ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2 --from --gas 2000000`,