address comments from review

This commit is contained in:
Federico Kunze 2020-04-30 13:16:30 -04:00
parent 0ee0dd8c41
commit 462dad4e93
No known key found for this signature in database
GPG Key ID: 655F93A970080A30
2 changed files with 3 additions and 14 deletions

View File

@ -135,6 +135,9 @@ test:
test-rest: test-rest:
rest_test/./run_all_tests_from_make.sh rest_test/./run_all_tests_from_make.sh
# Run cli integration tests
# `-p 4` to use 4 cores, `-tags cli_test` to tell go not to ignore the cli package
# These tests use the `kvd` or `kvcli` binaries in the build dir, or in `$BUILDDIR` if that env var is set.
test-cli: build test-cli: build
@go test ./cli_test -tags cli_test -v -p 4 @go test ./cli_test -tags cli_test -v -p 4

View File

@ -1,14 +0,0 @@
# CLI Integration tests
Run the full suite:
```bash
make build
go test -v -p 4 ./cli_test -tags cli_test
```
`-v` for verbose, `-p 4` to use 4 cores, `-tags cli_test` a build tag (specified in `cli_test.go`) to tell go not to ignore the package
> NOTE: While the full suite runs in parallel, some of the tests can take up to a minute to complete
> NOTE: The tests will use the `kvd` or `kvcli` binaries in the build dir. Or in `$BUILDDIR` if that env var is set.