From 3ae217e92717667cecf2603d9d7df7a0d3d6a9db Mon Sep 17 00:00:00 2001 From: rhuairahrighairigh Date: Sat, 1 Sep 2018 14:37:10 -0400 Subject: [PATCH] prioritise todos --- internal/x/paychan/README.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/internal/x/paychan/README.md b/internal/x/paychan/README.md index 30a8812c..1d9a312c 100644 --- a/internal/x/paychan/README.md +++ b/internal/x/paychan/README.md @@ -7,16 +7,17 @@ Simplifications: TODO + - in code TODOs + - write basic cmds + - Tidy up - method descriptions, heading comments, remove uneccessary comments, README/docs - chnge module name to "channel"? - Find a better name for Queue - clarify distinction between int slice and abstract queue concept - - refactor queue into one object - - Do all the small functions need to be methods on the keeper or can they just be floating around? - - Tidy up - standardise var names, method descriptions, heading comments - - any problem in signing your own address? - - Gas + - write some sort of integration test - find nicer name for payout - - tags - return channel id - - create custom errors instead of using sdk.ErrInternal - - maybe split off signatures from update as with txs/msgs - testing easier, code easier to use, doesn't store sigs unecessarily on chain + - add Gas usage + - add tags (return channel id on creation) + - use custom errors instead of using sdk.ErrInternal + - split off signatures from update as with txs/msgs - testing easier, code easier to use, doesn't store sigs unecessarily on chain - consider removing pubKey from UpdateSignature - instead let channel module access accountMapper - remove printout from tests when app initialised + - refactor queue into one object