From 1355bd6ab10599f7991e2e4076f0cbfb7b50ddef Mon Sep 17 00:00:00 2001 From: MiniFrenchBread <103425574+MiniFrenchBread@users.noreply.github.com> Date: Sat, 10 Aug 2024 10:24:11 +0800 Subject: [PATCH] fix: missing designers (#62) * fix: add dasigners back * test: remove manually initialize genesis * feat: generate all missing epochs on begin block; only panic on smaller block height * chore: add logs, fix EpochBlocks --- app/app.go | 4 ++++ x/dasigners/v1/keeper/abci.go | 17 ++++++++++++++--- x/dasigners/v1/keeper/abci_test.go | 22 +++++++++++++++++----- x/dasigners/v1/keeper/keeper_test.go | 3 +-- 4 files changed, 36 insertions(+), 10 deletions(-) diff --git a/app/app.go b/app/app.go index b2337526..10545dec 100644 --- a/app/app.go +++ b/app/app.go @@ -670,6 +670,7 @@ func NewApp( // nil InflationCalculationFn, use SDK's default inflation function mint.NewAppModule(appCodec, app.mintKeeper, app.accountKeeper, nil, mintSubspace), ibcwasm.NewAppModule(app.ibcWasmClientKeeper), + dasigners.NewAppModule(app.dasignersKeeper, *app.stakingKeeper), ) // Warning: Some begin blockers must run before others. Ensure the dependencies are understood before modifying this list. @@ -714,6 +715,7 @@ func NewApp( consensusparamtypes.ModuleName, packetforwardtypes.ModuleName, ibcwasmtypes.ModuleName, + dasignerstypes.ModuleName, ) // Warning: Some end blockers must run before others. Ensure the dependencies are understood before modifying this list. @@ -748,6 +750,7 @@ func NewApp( consensusparamtypes.ModuleName, packetforwardtypes.ModuleName, ibcwasmtypes.ModuleName, + dasignerstypes.ModuleName, ) // Warning: Some init genesis methods must run before others. Ensure the dependencies are understood before modifying this list @@ -781,6 +784,7 @@ func NewApp( packetforwardtypes.ModuleName, crisistypes.ModuleName, // runs the invariants at genesis, should run after other modules ibcwasmtypes.ModuleName, + dasignerstypes.ModuleName, ) app.mm.RegisterInvariants(&app.crisisKeeper) diff --git a/x/dasigners/v1/keeper/abci.go b/x/dasigners/v1/keeper/abci.go index cb1bde33..32d41d89 100644 --- a/x/dasigners/v1/keeper/abci.go +++ b/x/dasigners/v1/keeper/abci.go @@ -2,6 +2,7 @@ package keeper import ( "bytes" + "fmt" "math/big" "sort" @@ -16,7 +17,8 @@ type Ballot struct { content []byte } -func (k Keeper) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) { +// generateOneEpoch generate one epoch and returns true if there is a new epoch generated +func (k Keeper) generateOneEpoch(ctx sdk.Context) bool { epochNumber, err := k.GetEpochNumber(ctx) if err != nil { k.Logger(ctx).Error("[BeginBlock] cannot get epoch number") @@ -25,12 +27,14 @@ func (k Keeper) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) { params := k.GetParams(ctx) expectedEpoch := uint64(ctx.BlockHeight()) / params.EpochBlocks if expectedEpoch == epochNumber { - return + return false } - if expectedEpoch > epochNumber+1 || expectedEpoch < epochNumber { + if expectedEpoch < epochNumber { panic("block height is not continuous") } + expectedEpoch = epochNumber + 1 // new epoch + k.Logger(ctx).Info(fmt.Sprintf("[BeginBlock] generating epoch %v", expectedEpoch)) registrations := []Ballot{} k.IterateRegistrations(ctx, expectedEpoch, func(account string, signature []byte) (stop bool) { registrations = append(registrations, Ballot{ @@ -106,4 +110,11 @@ func (k Keeper) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) { // save to store k.SetEpochQuorums(ctx, expectedEpoch, quorums) k.SetEpochNumber(ctx, expectedEpoch) + k.Logger(ctx).Info(fmt.Sprintf("[BeginBlock] epoch %v generated, with %v quorums", expectedEpoch, len(quorums.Quorums))) + return true +} + +func (k Keeper) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) { + for k.generateOneEpoch(ctx) { + } } diff --git a/x/dasigners/v1/keeper/abci_test.go b/x/dasigners/v1/keeper/abci_test.go index 701eb687..424abe9c 100644 --- a/x/dasigners/v1/keeper/abci_test.go +++ b/x/dasigners/v1/keeper/abci_test.go @@ -3,7 +3,6 @@ package keeper_test import ( "testing" - "github.com/0glabs/0g-chain/x/dasigners/v1" "github.com/0glabs/0g-chain/x/dasigners/v1/keeper" "github.com/0glabs/0g-chain/x/dasigners/v1/testutil" "github.com/0glabs/0g-chain/x/dasigners/v1/types" @@ -19,16 +18,29 @@ type AbciTestSuite struct { func (suite *AbciTestSuite) TestBeginBlock_NotContinuous() { // suite.App.InitializeFromGenesisStates() - dasigners.InitGenesis(suite.Ctx, suite.Keeper, *types.DefaultGenesisState()) + // dasigners.InitGenesis(suite.Ctx, suite.Keeper, *types.DefaultGenesisState()) params := suite.Keeper.GetParams(suite.Ctx) - suite.Require().Panics(func() { - suite.Keeper.BeginBlock(suite.Ctx.WithBlockHeight(int64(params.EpochBlocks*2)), abci.RequestBeginBlock{}) + suite.Assert().EqualValues(params, types.DefaultGenesisState().Params) + + epoch, err := suite.Keeper.GetEpochNumber(suite.Ctx) + suite.Require().NoError(err) + suite.Assert().EqualValues(epoch, 0) + + suite.Assert().NotPanics(func() { + suite.Keeper.BeginBlock(suite.Ctx.WithBlockHeight(int64(params.EpochBlocks*10)), abci.RequestBeginBlock{}) + }) + epoch, err = suite.Keeper.GetEpochNumber(suite.Ctx) + suite.Require().NoError(err) + suite.Assert().EqualValues(epoch, 10) + + suite.Assert().Panics(func() { + suite.Keeper.BeginBlock(suite.Ctx.WithBlockHeight(int64(params.EpochBlocks*9)), abci.RequestBeginBlock{}) }, "block height is not continuous") } func (suite *AbciTestSuite) TestBeginBlock_Success() { // suite.App.InitializeFromGenesisStates() - dasigners.InitGenesis(suite.Ctx, suite.Keeper, *types.DefaultGenesisState()) + // dasigners.InitGenesis(suite.Ctx, suite.Keeper, *types.DefaultGenesisState()) suite.Keeper.SetParams(suite.Ctx, types.Params{ TokensPerVote: 10, MaxVotesPerSigner: 200, diff --git a/x/dasigners/v1/keeper/keeper_test.go b/x/dasigners/v1/keeper/keeper_test.go index fda2c698..d25b38c6 100644 --- a/x/dasigners/v1/keeper/keeper_test.go +++ b/x/dasigners/v1/keeper/keeper_test.go @@ -7,7 +7,6 @@ import ( "testing" "github.com/0glabs/0g-chain/crypto/bn254util" - "github.com/0glabs/0g-chain/x/dasigners/v1" "github.com/0glabs/0g-chain/x/dasigners/v1/keeper" "github.com/0glabs/0g-chain/x/dasigners/v1/testutil" "github.com/0glabs/0g-chain/x/dasigners/v1/types" @@ -312,7 +311,7 @@ func (suite *KeeperTestSuite) queryAggregatePubkeyG1(params types.Params) { func (suite *KeeperTestSuite) Test_Keeper() { // suite.App.InitializeFromGenesisStates() - dasigners.InitGenesis(suite.Ctx, suite.Keeper, *types.DefaultGenesisState()) + // dasigners.InitGenesis(suite.Ctx, suite.Keeper, *types.DefaultGenesisState()) // add delegation params := suite.Keeper.GetParams(suite.Ctx) suite.AddDelegation(signer1, signer1, keeper.BondedConversionRate.Mul(sdk.NewIntFromUint64(params.TokensPerVote)))