2021-06-21 21:05:17 +00:00
|
|
|
package keeper_test
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
|
|
|
|
"github.com/cosmos/cosmos-sdk/codec"
|
|
|
|
"github.com/cosmos/cosmos-sdk/store"
|
|
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
|
|
"github.com/cosmos/cosmos-sdk/x/params"
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
|
|
"github.com/tendermint/tendermint/libs/log"
|
|
|
|
db "github.com/tendermint/tm-db"
|
|
|
|
|
|
|
|
"github.com/kava-labs/kava/app"
|
|
|
|
"github.com/kava-labs/kava/x/incentive/keeper"
|
|
|
|
"github.com/kava-labs/kava/x/incentive/types"
|
|
|
|
)
|
|
|
|
|
|
|
|
// NewTestContext sets up a basic context with an in-memory db
|
|
|
|
func NewTestContext(requiredStoreKeys ...sdk.StoreKey) sdk.Context {
|
|
|
|
memDB := db.NewMemDB()
|
|
|
|
cms := store.NewCommitMultiStore(memDB)
|
|
|
|
|
|
|
|
for _, key := range requiredStoreKeys {
|
|
|
|
cms.MountStoreWithDB(key, sdk.StoreTypeIAVL, nil)
|
|
|
|
}
|
|
|
|
|
|
|
|
cms.LoadLatestVersion()
|
|
|
|
|
|
|
|
return sdk.NewContext(cms, abci.Header{}, false, log.NewNopLogger())
|
|
|
|
}
|
|
|
|
|
|
|
|
// unitTester is a wrapper around suite.Suite, with common functionality for keeper unit tests.
|
|
|
|
// It can be embedded in structs the same way as suite.Suite.
|
|
|
|
type unitTester struct {
|
|
|
|
suite.Suite
|
|
|
|
keeper keeper.Keeper
|
|
|
|
ctx sdk.Context
|
|
|
|
|
|
|
|
cdc *codec.Codec
|
|
|
|
incentiveStoreKey sdk.StoreKey
|
|
|
|
}
|
|
|
|
|
|
|
|
func (suite *unitTester) SetupSuite() {
|
|
|
|
suite.cdc = app.MakeCodec()
|
|
|
|
|
|
|
|
suite.incentiveStoreKey = sdk.NewKVStoreKey(types.StoreKey)
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
func (suite *unitTester) SetupTest() {
|
|
|
|
suite.ctx = NewTestContext(suite.incentiveStoreKey)
|
2021-07-07 13:23:06 +00:00
|
|
|
suite.keeper = suite.NewKeeper(&fakeParamSubspace{}, nil, nil, nil, nil, nil, nil)
|
2021-06-21 21:05:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func (suite *unitTester) TearDownTest() {
|
|
|
|
suite.keeper = keeper.Keeper{}
|
|
|
|
suite.ctx = sdk.Context{}
|
|
|
|
}
|
|
|
|
|
2021-07-07 13:23:06 +00:00
|
|
|
func (suite *unitTester) NewKeeper(paramSubspace types.ParamSubspace, sk types.SupplyKeeper, cdpk types.CdpKeeper, hk types.HardKeeper, ak types.AccountKeeper, stk types.StakingKeeper, swk types.SwapKeeper) keeper.Keeper {
|
|
|
|
return keeper.NewKeeper(suite.cdc, suite.incentiveStoreKey, paramSubspace, sk, cdpk, hk, ak, stk, swk)
|
2021-06-21 21:05:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func (suite *unitTester) storeGlobalBorrowIndexes(indexes types.MultiRewardIndexes) {
|
|
|
|
for _, i := range indexes {
|
|
|
|
suite.keeper.SetHardBorrowRewardIndexes(suite.ctx, i.CollateralType, i.RewardIndexes)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
func (suite *unitTester) storeGlobalSupplyIndexes(indexes types.MultiRewardIndexes) {
|
|
|
|
for _, i := range indexes {
|
|
|
|
suite.keeper.SetHardSupplyRewardIndexes(suite.ctx, i.CollateralType, i.RewardIndexes)
|
|
|
|
}
|
|
|
|
}
|
2021-07-07 13:23:06 +00:00
|
|
|
func (suite *unitTester) storeGlobalDelegatorIndexes(multiRewardIndexes types.MultiRewardIndexes) {
|
|
|
|
// Hardcoded to use bond denom
|
|
|
|
multiRewardIndex, _ := multiRewardIndexes.GetRewardIndex(types.BondDenom)
|
2021-07-07 16:50:14 +00:00
|
|
|
suite.keeper.SetDelegatorRewardIndexes(suite.ctx, types.BondDenom, multiRewardIndex.RewardIndexes)
|
2021-07-07 13:23:06 +00:00
|
|
|
}
|
|
|
|
func (suite *unitTester) storeGlobalSwapIndexes(indexes types.MultiRewardIndexes) {
|
|
|
|
for _, i := range indexes {
|
|
|
|
suite.keeper.SetSwapRewardIndexes(suite.ctx, i.CollateralType, i.RewardIndexes)
|
|
|
|
}
|
|
|
|
}
|
2021-06-21 21:05:17 +00:00
|
|
|
|
2021-07-07 16:50:14 +00:00
|
|
|
func (suite *unitTester) storeHardClaim(claim types.HardLiquidityProviderClaim) {
|
2021-06-21 21:05:17 +00:00
|
|
|
suite.keeper.SetHardLiquidityProviderClaim(suite.ctx, claim)
|
|
|
|
}
|
2021-07-07 16:50:14 +00:00
|
|
|
func (suite *unitTester) storeDelegatorClaim(claim types.DelegatorClaim) {
|
|
|
|
suite.keeper.SetDelegatorClaim(suite.ctx, claim)
|
|
|
|
}
|
Swap users accumulate rewards (#950)
* add swap claim type
* add store methods for swap claims
* add swap claims to genesis state
* tidy up cdp and hard hook doc comments
* add uncalled hooks to the swap keeper
* add swap rewards sync method
* add swap rewards init method
* connect swap rewards via swap hooks
* Update querier and client for swap claims (#951)
* refactor querier to dedupe code
* add swap claims querier endpoint
* add swap claim querying to rest
* add swap claim querying to cli
* add keeper method to iterate swap reward indexes
* simplify reward-factors query endpoint, add swap
* update swap hook to match latest swap branch
* rename func to not collide with latest swap branch
* Squash merge swap-acceptance branch (#956)
* add failing acceptance test for a user depositing into a pool
* implement GetAccount test helper
* implement swap.MsgDeposit for creating and adding liquidity to a pool
* update aliases, add event types, and fix typo/compiler errors in handler
test
* use only aliases names in handler test (don't use swap types -- ensures
we have run aliasgen), add assertion for even type message
* implement account and module account balance checks in handler test
* fill out handler assertions for testing keeper state and events
* update signed json representation and register swap/MsgDeposit for
proper encoding
* fill out boilerplate to get handler test to compile
* alias gen for pool
* add handling of message type; fill in deposit keeper method for
succesful compile; noop but test assertions now run up to module acc not
nil check
* add module account permissions for swap module -- fixes module account
creation; pass account keeper and supply keeper into swap keeper to
allow the ability to work with user and module accounts
* implement create pool logic for msg deposit; allows creation of a of new
pool, checking params to see if it is allowed. Initi shares are set,
and senders number of shares are stored
* Swap migrations scaffolding (#925)
* swap module scaffolding
* global swap fee
* can't think of a reason for begin blocker; removing for abci.go for now;
* test pair types; refactor pair name logic; simplify pairs validation and
fix stack overflow error
* check comparison
* use test package
* init swap module genesis
* add basic marshall tests
* remove reward apy from pairs
* fix integration helpers
* use max swap fee constant; fix validation of swap fee; add tests to
cover param validation and param set setup
* use noerror over nil
* start genesis tests
* test param set validation mirrors param validation
* add genesis tests
* remove print statement
* add subtests for genesis test cases; add extra querier test for unknown
route; add keeper params testing
* add spec
* update swagger
* find replace hard -> swap in comments
* remove unused method
* rename pairs to allowed pools; pool is more commonly used, and
allowedPool makes it more clear what swap parameter is for. In
addition, we won't conflict with Pool data structure for storing a
created pool in the store.
* remove generated link
* missed spec rename
* validate token order for allowed pools
* fix swagger
* json should be snakecase; change allowedPools to allowed_pools
* add legacy types
* add swap genesis to v0_15 migration
* add legacy types
* add swap genesis to v0_15 migration
* migration revisions
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
* keeper todos
* update keeper tests
* type todos
* update types tests
* tx deposit cli cmd
* tx deposit rest
* Swap module simulation scaffolding (#924)
* sims scaffolding
* add noop operation
* genesis revisions
* add param changes
* mvoe persistance methods to main keeper file, consolidate tests
* make helper methods private. they are tested via deposit method, and
unit testing them would make test suite brittle and refactoring
difficult
* use more clear coin variables
* code 1 is reserved, use code 2 and sequence all errors
* remove todo
* Implement deadline for swap module module message. This is implemented in
handler with a interface to easily apply to it to all messages, and
separate msg validation concerns from the keeper
* move allowed pools to params -- let pool and pool_test focus on pool domain logic, not
parameter & governance concerns
* update alias
* add unitless implementatin of constant product liquidity pool to
isolate and enapsulate liquidity logic. Swap methods interfaces are
added, but implementation not yet added
* nits and todos
* add ErrInvalidPool
* add tests for edge cases around pool depletion; add explicit panic for
edge case that results in a pool reserve being zero; handle pool
reinitialization if it is empty
* touch up comments and flush out the rest of assertions
* add data structures for keeper state storage separate from pool domain
objects, and improve structure for easier querying
* rename pool name to pool key for events
* add support for a denominated pool that uses sdk.Coins and sdk.Coin
arguments, keeping tracking of the units in the base pool. This gives
nice separation between pool logic, and coin/denom logic
* refactor keeper to use new records for storage, and implement pool
deposit using the denominated pool
* address previous PR comment - reminder for migration if changing
account permissions
* msg deposit should validate that denoms are not equal
* add godoc comments
* golint and some poolName -> poolID cleanup
* implement adding liquidity to an existing pool
* hardcode pools in sims
* touch up comment
* withdraw keeper logic
* withdraw type updates
* add withdraw msg tx handler
* initial withdraw test
* fix panic
* use new denominated pool with existing shares
* fix: check args on deposit cmd
* add slippage limit check for depositing to an existing pool
* send coins just before event emission
* check liquidity returned is greater than zero for both coins; ensure
returned number of shares are greater than zero
* add deadline to msgwithdraw
* register msgwithdraw
* scaffold msgwithdraw types test
* register the correct msg
* modify swap functions to also return the amount paid for the pool swap
fee. This will be used to calculate slippage and for event tracking
* add slippage types
* add expected withdrawal coins
* calculate slippage against expected coins
* update withdraw keeper tests
* spelling, improve comments on add liquidity math
* typo
* typo
* grammer
* typo / grammer
* remove pool_id from withdraw msg
* add slippage to tx cmd
* TestWithdraw_Partial
* nit
* add withdraw no pool, no deposit record tests
* drop event check on partial withdraw test
* fix broken link
* fix broken link
* resolve merge conflicts
* ensure swap fee can not be equal to 1; add full implementation of swap
pool methods; these implementation ensure that the pool invariant is
always greater or equal to the previous invariant
* refactor duplicated code into private swap methods
* add runtime assertion to always ensure invariant is greater or equal
to the previous invariant sub fee on swaps
* improve comments for base pool swap functions
* add swap exact input and output methods to denominated pool that wrap
the base pool interface for swapping
* comment touch ups
* more comment touchups
* fix msg deposit struct tag (#943)
* use better name for swap calculation private methods
* nits: golint
* fix misspelling in method name
* Add HARD token governance committee for Hard module (#941)
* add hard gov token committee
* revisions: update migration
* revisions: update test/data file
* initial revisions
* add TokenCommittee JSONMarshal test
* fix SetPermissions method
* remove BaseCommittee Type field
* add incentive params to allowed params
* Add SWP token governance committee for Swap module (#946)
* add swp token commitee to migration
* update test, add gen export utility method
* final revisions: add TODO
* remove slippage from withdraw to use min values for coins; add
additional validation test cases
* update alias for swap module
* add withdraw tests to handler for increased coverage; note: first pass,
improvements still yet to be made here
* refact withdraw keeper to use min amounts; panic for cases that do not
happen in normal situations
* lint fixes
* use total shares to track if pool should be deleted; add more in depth
withdraw comment
* add exact args for withdraw cmd
* extract record update methods
* update depositor share record if it exists -- do not overwrite an
existing record; ensures no loss of shares if the same address deposits
more than once
* Swap queries: deposit, pool, pools (#949)
* query deposits types
* implement deposit querier keeper methods
* query deposits CLI
* query deposits REST
* query types for pool/pools
* pool/pools querier keeper methods
* pool/pools CLI
* pool/pools REST
* basic pool/pools query tests
* basic deposit querier test
* iterate share records via owner bytes
* nit: add example for querying deposits by owner only
Co-authored-by: karzak <kjydavis3@gmail.com>
* feat: add REST tx handler for swap LP withdrawals
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: Denali Marsh <denali@kava.io>
Co-authored-by: denalimarsh <denalimarsh@gmail.com>
Co-authored-by: karzak <kjydavis3@gmail.com>
* expand incentive cli query docs
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: Denali Marsh <denali@kava.io>
Co-authored-by: denalimarsh <denalimarsh@gmail.com>
Co-authored-by: karzak <kjydavis3@gmail.com>
* minor update to godoc comment
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: Denali Marsh <denali@kava.io>
Co-authored-by: denalimarsh <denalimarsh@gmail.com>
Co-authored-by: karzak <kjydavis3@gmail.com>
2021-07-13 12:35:02 +00:00
|
|
|
func (suite *unitTester) storeSwapClaim(claim types.SwapClaim) {
|
|
|
|
suite.keeper.SetSwapClaim(suite.ctx, claim)
|
|
|
|
}
|
2021-07-07 16:50:14 +00:00
|
|
|
|
2021-06-21 21:05:17 +00:00
|
|
|
type fakeParamSubspace struct {
|
|
|
|
params types.Params
|
|
|
|
}
|
|
|
|
|
|
|
|
func (subspace *fakeParamSubspace) GetParamSet(_ sdk.Context, ps params.ParamSet) {
|
|
|
|
*(ps.(*types.Params)) = subspace.params
|
|
|
|
}
|
|
|
|
func (subspace *fakeParamSubspace) SetParamSet(_ sdk.Context, ps params.ParamSet) {
|
|
|
|
subspace.params = *(ps.(*types.Params))
|
|
|
|
}
|
|
|
|
func (subspace *fakeParamSubspace) HasKeyTable() bool {
|
2021-07-07 13:23:06 +00:00
|
|
|
// return true so the keeper does not try to call WithKeyTable, which does nothing
|
2021-06-21 21:05:17 +00:00
|
|
|
return true
|
|
|
|
}
|
|
|
|
func (subspace *fakeParamSubspace) WithKeyTable(params.KeyTable) params.Subspace {
|
|
|
|
// return an non-functional subspace to satisfy the interface
|
|
|
|
return params.Subspace{}
|
|
|
|
}
|
|
|
|
|
|
|
|
func arbitraryCoin() sdk.Coin {
|
|
|
|
return c("hard", 1e9)
|
|
|
|
}
|
|
|
|
|
|
|
|
func arbitraryCoins() sdk.Coins {
|
|
|
|
return cs(c("btcb", 1))
|
|
|
|
}
|
|
|
|
|
|
|
|
func arbitraryCoinsWithDenoms(denom ...string) sdk.Coins {
|
|
|
|
const arbitraryAmount = 1 // must be > 0 as sdk.Coins type only stores positive amounts
|
|
|
|
coins := sdk.NewCoins()
|
|
|
|
for _, d := range denom {
|
|
|
|
coins = coins.Add(sdk.NewInt64Coin(d, arbitraryAmount))
|
|
|
|
}
|
|
|
|
return coins
|
|
|
|
}
|
|
|
|
|
|
|
|
func arbitraryAddress() sdk.AccAddress {
|
|
|
|
_, addresses := app.GeneratePrivKeyAddressPairs(1)
|
|
|
|
return addresses[0]
|
|
|
|
}
|
|
|
|
func arbitraryValidatorAddress() sdk.ValAddress {
|
|
|
|
return generateValidatorAddresses(1)[0]
|
|
|
|
}
|
|
|
|
func generateValidatorAddresses(n int) []sdk.ValAddress {
|
|
|
|
_, addresses := app.GeneratePrivKeyAddressPairs(n)
|
|
|
|
var valAddresses []sdk.ValAddress
|
|
|
|
for _, a := range addresses {
|
|
|
|
valAddresses = append(valAddresses, sdk.ValAddress(a))
|
|
|
|
}
|
|
|
|
return valAddresses
|
|
|
|
}
|
|
|
|
|
|
|
|
var nonEmptyMultiRewardIndexes = types.MultiRewardIndexes{
|
|
|
|
{
|
|
|
|
CollateralType: "bnb",
|
|
|
|
RewardIndexes: types.RewardIndexes{
|
|
|
|
{
|
|
|
|
CollateralType: "hard",
|
|
|
|
RewardFactor: d("0.02"),
|
|
|
|
},
|
|
|
|
{
|
|
|
|
CollateralType: "ukava",
|
|
|
|
RewardFactor: d("0.04"),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
CollateralType: "btcb",
|
|
|
|
RewardIndexes: types.RewardIndexes{
|
|
|
|
{
|
|
|
|
CollateralType: "hard",
|
|
|
|
RewardFactor: d("0.2"),
|
|
|
|
},
|
|
|
|
{
|
|
|
|
CollateralType: "ukava",
|
|
|
|
RewardFactor: d("0.4"),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
func extractCollateralTypes(indexes types.MultiRewardIndexes) []string {
|
|
|
|
var denoms []string
|
|
|
|
for _, ri := range indexes {
|
|
|
|
denoms = append(denoms, ri.CollateralType)
|
|
|
|
}
|
|
|
|
return denoms
|
|
|
|
}
|
|
|
|
|
|
|
|
func increaseAllRewardFactors(indexes types.MultiRewardIndexes) types.MultiRewardIndexes {
|
|
|
|
increasedIndexes := make(types.MultiRewardIndexes, len(indexes))
|
|
|
|
copy(increasedIndexes, indexes)
|
|
|
|
|
|
|
|
for i := range increasedIndexes {
|
|
|
|
increasedIndexes[i].RewardIndexes = increaseRewardFactors(increasedIndexes[i].RewardIndexes)
|
|
|
|
}
|
|
|
|
return increasedIndexes
|
|
|
|
}
|
|
|
|
|
|
|
|
func increaseRewardFactors(indexes types.RewardIndexes) types.RewardIndexes {
|
|
|
|
increasedIndexes := make(types.RewardIndexes, len(indexes))
|
|
|
|
copy(increasedIndexes, indexes)
|
|
|
|
|
|
|
|
for i := range increasedIndexes {
|
|
|
|
increasedIndexes[i].RewardFactor = increasedIndexes[i].RewardFactor.MulInt64(2)
|
|
|
|
}
|
|
|
|
return increasedIndexes
|
|
|
|
}
|
|
|
|
|
|
|
|
func appendUniqueMultiRewardIndex(indexes types.MultiRewardIndexes) types.MultiRewardIndexes {
|
|
|
|
const uniqueDenom = "uniquedenom"
|
|
|
|
|
|
|
|
for _, mri := range indexes {
|
|
|
|
if mri.CollateralType == uniqueDenom {
|
|
|
|
panic(fmt.Sprintf("tried to add unique multi reward index with denom '%s', but denom already existed", uniqueDenom))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return append(indexes, types.NewMultiRewardIndex(
|
|
|
|
uniqueDenom,
|
|
|
|
types.RewardIndexes{
|
|
|
|
{
|
|
|
|
CollateralType: "hard",
|
|
|
|
RewardFactor: d("0.02"),
|
|
|
|
},
|
|
|
|
{
|
|
|
|
CollateralType: "ukava",
|
|
|
|
RewardFactor: d("0.04"),
|
|
|
|
},
|
|
|
|
},
|
|
|
|
),
|
|
|
|
)
|
|
|
|
}
|
|
|
|
|
|
|
|
func appendUniqueEmptyMultiRewardIndex(indexes types.MultiRewardIndexes) types.MultiRewardIndexes {
|
|
|
|
const uniqueDenom = "uniquedenom"
|
|
|
|
|
|
|
|
for _, mri := range indexes {
|
|
|
|
if mri.CollateralType == uniqueDenom {
|
|
|
|
panic(fmt.Sprintf("tried to add unique multi reward index with denom '%s', but denom already existed", uniqueDenom))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return append(indexes, types.NewMultiRewardIndex(uniqueDenom, nil))
|
|
|
|
}
|
|
|
|
|
|
|
|
func appendUniqueRewardIndexToFirstItem(indexes types.MultiRewardIndexes) types.MultiRewardIndexes {
|
|
|
|
newIndexes := make(types.MultiRewardIndexes, len(indexes))
|
|
|
|
copy(newIndexes, indexes)
|
|
|
|
|
|
|
|
newIndexes[0].RewardIndexes = appendUniqueRewardIndex(newIndexes[0].RewardIndexes)
|
|
|
|
return newIndexes
|
|
|
|
}
|
|
|
|
|
|
|
|
func appendUniqueRewardIndex(indexes types.RewardIndexes) types.RewardIndexes {
|
|
|
|
const uniqueDenom = "uniquereward"
|
|
|
|
|
|
|
|
for _, mri := range indexes {
|
|
|
|
if mri.CollateralType == uniqueDenom {
|
|
|
|
panic(fmt.Sprintf("tried to add unique reward index with denom '%s', but denom already existed", uniqueDenom))
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return append(
|
|
|
|
indexes,
|
|
|
|
types.NewRewardIndex(uniqueDenom, d("0.02")),
|
|
|
|
)
|
|
|
|
}
|