Squash merge swap-acceptance branch (#956)
* add failing acceptance test for a user depositing into a pool
* implement GetAccount test helper
* implement swap.MsgDeposit for creating and adding liquidity to a pool
* update aliases, add event types, and fix typo/compiler errors in handler
test
* use only aliases names in handler test (don't use swap types -- ensures
we have run aliasgen), add assertion for even type message
* implement account and module account balance checks in handler test
* fill out handler assertions for testing keeper state and events
* update signed json representation and register swap/MsgDeposit for
proper encoding
* fill out boilerplate to get handler test to compile
* alias gen for pool
* add handling of message type; fill in deposit keeper method for
succesful compile; noop but test assertions now run up to module acc not
nil check
* add module account permissions for swap module -- fixes module account
creation; pass account keeper and supply keeper into swap keeper to
allow the ability to work with user and module accounts
* implement create pool logic for msg deposit; allows creation of a of new
pool, checking params to see if it is allowed. Initi shares are set,
and senders number of shares are stored
* Swap migrations scaffolding (#925)
* swap module scaffolding
* global swap fee
* can't think of a reason for begin blocker; removing for abci.go for now;
* test pair types; refactor pair name logic; simplify pairs validation and
fix stack overflow error
* check comparison
* use test package
* init swap module genesis
* add basic marshall tests
* remove reward apy from pairs
* fix integration helpers
* use max swap fee constant; fix validation of swap fee; add tests to
cover param validation and param set setup
* use noerror over nil
* start genesis tests
* test param set validation mirrors param validation
* add genesis tests
* remove print statement
* add subtests for genesis test cases; add extra querier test for unknown
route; add keeper params testing
* add spec
* update swagger
* find replace hard -> swap in comments
* remove unused method
* rename pairs to allowed pools; pool is more commonly used, and
allowedPool makes it more clear what swap parameter is for. In
addition, we won't conflict with Pool data structure for storing a
created pool in the store.
* remove generated link
* missed spec rename
* validate token order for allowed pools
* fix swagger
* json should be snakecase; change allowedPools to allowed_pools
* add legacy types
* add swap genesis to v0_15 migration
* add legacy types
* add swap genesis to v0_15 migration
* migration revisions
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
* keeper todos
* update keeper tests
* type todos
* update types tests
* tx deposit cli cmd
* tx deposit rest
* Swap module simulation scaffolding (#924)
* sims scaffolding
* add noop operation
* genesis revisions
* add param changes
* mvoe persistance methods to main keeper file, consolidate tests
* make helper methods private. they are tested via deposit method, and
unit testing them would make test suite brittle and refactoring
difficult
* use more clear coin variables
* code 1 is reserved, use code 2 and sequence all errors
* remove todo
* Implement deadline for swap module module message. This is implemented in
handler with a interface to easily apply to it to all messages, and
separate msg validation concerns from the keeper
* move allowed pools to params -- let pool and pool_test focus on pool domain logic, not
parameter & governance concerns
* update alias
* add unitless implementatin of constant product liquidity pool to
isolate and enapsulate liquidity logic. Swap methods interfaces are
added, but implementation not yet added
* nits and todos
* add ErrInvalidPool
* add tests for edge cases around pool depletion; add explicit panic for
edge case that results in a pool reserve being zero; handle pool
reinitialization if it is empty
* touch up comments and flush out the rest of assertions
* add data structures for keeper state storage separate from pool domain
objects, and improve structure for easier querying
* rename pool name to pool key for events
* add support for a denominated pool that uses sdk.Coins and sdk.Coin
arguments, keeping tracking of the units in the base pool. This gives
nice separation between pool logic, and coin/denom logic
* refactor keeper to use new records for storage, and implement pool
deposit using the denominated pool
* address previous PR comment - reminder for migration if changing
account permissions
* msg deposit should validate that denoms are not equal
* add godoc comments
* golint and some poolName -> poolID cleanup
* implement adding liquidity to an existing pool
* hardcode pools in sims
* touch up comment
* withdraw keeper logic
* withdraw type updates
* add withdraw msg tx handler
* initial withdraw test
* fix panic
* use new denominated pool with existing shares
* fix: check args on deposit cmd
* add slippage limit check for depositing to an existing pool
* send coins just before event emission
* check liquidity returned is greater than zero for both coins; ensure
returned number of shares are greater than zero
* add deadline to msgwithdraw
* register msgwithdraw
* scaffold msgwithdraw types test
* register the correct msg
* modify swap functions to also return the amount paid for the pool swap
fee. This will be used to calculate slippage and for event tracking
* add slippage types
* add expected withdrawal coins
* calculate slippage against expected coins
* update withdraw keeper tests
* spelling, improve comments on add liquidity math
* typo
* typo
* grammer
* typo / grammer
* remove pool_id from withdraw msg
* add slippage to tx cmd
* TestWithdraw_Partial
* nit
* add withdraw no pool, no deposit record tests
* drop event check on partial withdraw test
* fix broken link
* fix broken link
* resolve merge conflicts
* ensure swap fee can not be equal to 1; add full implementation of swap
pool methods; these implementation ensure that the pool invariant is
always greater or equal to the previous invariant
* refactor duplicated code into private swap methods
* add runtime assertion to always ensure invariant is greater or equal
to the previous invariant sub fee on swaps
* improve comments for base pool swap functions
* add swap exact input and output methods to denominated pool that wrap
the base pool interface for swapping
* comment touch ups
* more comment touchups
* fix msg deposit struct tag (#943)
* use better name for swap calculation private methods
* nits: golint
* fix misspelling in method name
* Add HARD token governance committee for Hard module (#941)
* add hard gov token committee
* revisions: update migration
* revisions: update test/data file
* initial revisions
* add TokenCommittee JSONMarshal test
* fix SetPermissions method
* remove BaseCommittee Type field
* add incentive params to allowed params
* Add SWP token governance committee for Swap module (#946)
* add swp token commitee to migration
* update test, add gen export utility method
* final revisions: add TODO
* remove slippage from withdraw to use min values for coins; add
additional validation test cases
* update alias for swap module
* add withdraw tests to handler for increased coverage; note: first pass,
improvements still yet to be made here
* refact withdraw keeper to use min amounts; panic for cases that do not
happen in normal situations
* lint fixes
* use total shares to track if pool should be deleted; add more in depth
withdraw comment
* add exact args for withdraw cmd
* extract record update methods
* update depositor share record if it exists -- do not overwrite an
existing record; ensures no loss of shares if the same address deposits
more than once
* Swap queries: deposit, pool, pools (#949)
* query deposits types
* implement deposit querier keeper methods
* query deposits CLI
* query deposits REST
* query types for pool/pools
* pool/pools querier keeper methods
* pool/pools CLI
* pool/pools REST
* basic pool/pools query tests
* basic deposit querier test
* iterate share records via owner bytes
* nit: add example for querying deposits by owner only
Co-authored-by: karzak <kjydavis3@gmail.com>
* feat: add REST tx handler for swap LP withdrawals
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: Denali Marsh <denali@kava.io>
Co-authored-by: denalimarsh <denalimarsh@gmail.com>
Co-authored-by: karzak <kjydavis3@gmail.com>
2021-07-13 11:38:15 +00:00
|
|
|
package swap_test
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"fmt"
|
|
|
|
|
"testing"
|
|
|
|
|
"time"
|
|
|
|
|
|
|
|
|
|
"github.com/kava-labs/kava/x/swap"
|
|
|
|
|
"github.com/kava-labs/kava/x/swap/testutil"
|
|
|
|
|
|
|
|
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
|
|
|
"github.com/cosmos/cosmos-sdk/x/bank"
|
|
|
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
|
|
|
"github.com/tendermint/tendermint/crypto"
|
|
|
|
|
tmtime "github.com/tendermint/tendermint/types/time"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
var swapModuleAccountAddress = sdk.AccAddress(crypto.AddressHash([]byte(swap.ModuleAccountName)))
|
|
|
|
|
|
|
|
|
|
type handlerTestSuite struct {
|
|
|
|
|
testutil.Suite
|
|
|
|
|
handler sdk.Handler
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) SetupTest() {
|
|
|
|
|
suite.Suite.SetupTest()
|
|
|
|
|
suite.handler = swap.NewHandler(suite.Keeper)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestDeposit_CreatePool() {
|
|
|
|
|
pool := swap.NewAllowedPool("ukava", "usdx")
|
|
|
|
|
suite.Require().NoError(pool.Validate())
|
|
|
|
|
suite.Keeper.SetParams(suite.Ctx, swap.NewParams(swap.NewAllowedPools(pool), swap.DefaultSwapFee))
|
|
|
|
|
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin(pool.TokenA, sdk.NewInt(10e6)),
|
|
|
|
|
sdk.NewCoin(pool.TokenB, sdk.NewInt(50e6)),
|
|
|
|
|
)
|
|
|
|
|
depositor := suite.CreateAccount(balance)
|
|
|
|
|
|
|
|
|
|
deposit := swap.NewMsgDeposit(
|
|
|
|
|
depositor.GetAddress(),
|
|
|
|
|
sdk.NewCoin(pool.TokenA, depositor.GetCoins().AmountOf(pool.TokenA)),
|
|
|
|
|
sdk.NewCoin(pool.TokenB, depositor.GetCoins().AmountOf(pool.TokenB)),
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
res, err := suite.handler(suite.Ctx, deposit)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
suite.AccountBalanceEqual(depositor, sdk.Coins(nil))
|
|
|
|
|
suite.ModuleAccountBalanceEqual(balance)
|
|
|
|
|
suite.PoolLiquidityEqual(balance)
|
|
|
|
|
suite.PoolShareValueEqual(depositor, pool, balance)
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
sdk.EventTypeMessage,
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, swap.AttributeValueCategory),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeySender, depositor.GetAddress().String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
bank.EventTypeTransfer,
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeyRecipient, swapModuleAccountAddress.String()),
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeySender, depositor.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, balance.String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
swap.EventTypeSwapDeposit,
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyPoolID, swap.PoolID(pool.TokenA, pool.TokenB)),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyDepositor, depositor.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, balance.String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyShares, "22360679"),
|
|
|
|
|
))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestDeposit_DeadlineExceeded() {
|
|
|
|
|
pool := swap.NewAllowedPool("ukava", "usdx")
|
|
|
|
|
suite.Require().NoError(pool.Validate())
|
|
|
|
|
suite.Keeper.SetParams(suite.Ctx, swap.NewParams(swap.NewAllowedPools(pool), swap.DefaultSwapFee))
|
|
|
|
|
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin(pool.TokenA, sdk.NewInt(10e6)),
|
|
|
|
|
sdk.NewCoin(pool.TokenB, sdk.NewInt(50e6)),
|
|
|
|
|
)
|
|
|
|
|
depositor := suite.CreateAccount(balance)
|
|
|
|
|
|
|
|
|
|
deposit := swap.NewMsgDeposit(
|
|
|
|
|
depositor.GetAddress(),
|
|
|
|
|
sdk.NewCoin(pool.TokenA, depositor.GetCoins().AmountOf(pool.TokenA)),
|
|
|
|
|
sdk.NewCoin(pool.TokenB, depositor.GetCoins().AmountOf(pool.TokenB)),
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
suite.Ctx.BlockTime().Add(-1*time.Second).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
res, err := suite.handler(suite.Ctx, deposit)
|
|
|
|
|
suite.EqualError(err, fmt.Sprintf("deadline exceeded: block time %d >= deadline %d", suite.Ctx.BlockTime().Unix(), deposit.GetDeadline().Unix()))
|
|
|
|
|
suite.Nil(res)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestDeposit_ExistingPool() {
|
|
|
|
|
pool := swap.NewAllowedPool("ukava", "usdx")
|
|
|
|
|
reserves := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(50e6)),
|
|
|
|
|
)
|
|
|
|
|
err := suite.CreatePool(reserves)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(1e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5e6)),
|
|
|
|
|
)
|
|
|
|
|
depositor := suite.NewAccountFromAddr(sdk.AccAddress("new depositor"), balance)
|
|
|
|
|
|
|
|
|
|
deposit := swap.NewMsgDeposit(
|
|
|
|
|
depositor.GetAddress(),
|
|
|
|
|
sdk.NewCoin("usdx", depositor.GetCoins().AmountOf("usdx")),
|
|
|
|
|
sdk.NewCoin("ukava", depositor.GetCoins().AmountOf("ukava")),
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
res, err := suite.handler(suite.Ctx, deposit)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
expectedDeposit := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(1e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5e6)),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
expectedShareValue := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(999999)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(4999998)),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
suite.AccountBalanceEqual(depositor, balance.Sub(expectedDeposit))
|
|
|
|
|
suite.ModuleAccountBalanceEqual(reserves.Add(expectedDeposit...))
|
|
|
|
|
suite.PoolLiquidityEqual(reserves.Add(expectedDeposit...))
|
|
|
|
|
suite.PoolShareValueEqual(depositor, pool, expectedShareValue)
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
sdk.EventTypeMessage,
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, swap.AttributeValueCategory),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeySender, depositor.GetAddress().String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
bank.EventTypeTransfer,
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeyRecipient, swapModuleAccountAddress.String()),
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeySender, depositor.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, expectedDeposit.String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
swap.EventTypeSwapDeposit,
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyPoolID, swap.PoolID(pool.TokenA, pool.TokenB)),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyDepositor, depositor.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, expectedDeposit.String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyShares, "2236067"),
|
|
|
|
|
))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestDeposit_ExistingPool_SlippageFailure() {
|
|
|
|
|
reserves := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(50e6)),
|
|
|
|
|
)
|
|
|
|
|
err := suite.CreatePool(reserves)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(5e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5e6)),
|
|
|
|
|
)
|
|
|
|
|
depositor := suite.CreateAccount(balance)
|
|
|
|
|
|
|
|
|
|
deposit := swap.NewMsgDeposit(
|
|
|
|
|
depositor.GetAddress(),
|
|
|
|
|
sdk.NewCoin("usdx", depositor.GetCoins().AmountOf("usdx")),
|
|
|
|
|
sdk.NewCoin("ukava", depositor.GetCoins().AmountOf("ukava")),
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
res, err := suite.handler(suite.Ctx, deposit)
|
|
|
|
|
suite.EqualError(err, "slippage exceeded: slippage 4.000000000000000000 > limit 0.010000000000000000")
|
|
|
|
|
suite.Nil(res)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestWithdraw_AllShares() {
|
|
|
|
|
reserves := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(50e6)),
|
|
|
|
|
)
|
|
|
|
|
depositor := suite.CreateAccount(reserves)
|
|
|
|
|
pool := swap.NewAllowedPool(reserves[0].Denom, reserves[1].Denom)
|
|
|
|
|
suite.Require().NoError(pool.Validate())
|
|
|
|
|
suite.Keeper.SetParams(suite.Ctx, swap.NewParams(swap.NewAllowedPools(pool), swap.DefaultSwapFee))
|
|
|
|
|
|
|
|
|
|
err := suite.Keeper.Deposit(suite.Ctx, depositor.GetAddress(), reserves[0], reserves[1], sdk.MustNewDecFromStr("1"))
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
withdraw := swap.NewMsgWithdraw(
|
|
|
|
|
depositor.GetAddress(),
|
|
|
|
|
sdk.NewInt(22360679),
|
|
|
|
|
reserves[0],
|
|
|
|
|
reserves[1],
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
ctx := suite.App.NewContext(true, abci.Header{Height: 1, Time: tmtime.Now()})
|
|
|
|
|
res, err := suite.handler(ctx, withdraw)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
suite.AccountBalanceEqual(depositor, reserves)
|
|
|
|
|
suite.ModuleAccountBalanceEqual(sdk.Coins(nil))
|
|
|
|
|
suite.PoolDeleted("ukava", "usdx")
|
|
|
|
|
suite.PoolSharesDeleted(depositor.GetAddress(), "ukava", "usdx")
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
sdk.EventTypeMessage,
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, swap.AttributeValueCategory),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeySender, depositor.GetAddress().String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
bank.EventTypeTransfer,
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeyRecipient, depositor.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeySender, swapModuleAccountAddress.String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, reserves.String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
swap.EventTypeSwapWithdraw,
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyPoolID, swap.PoolID(pool.TokenA, pool.TokenB)),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyOwner, depositor.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, reserves.String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyShares, "22360679"),
|
|
|
|
|
))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestWithdraw_PartialShares() {
|
|
|
|
|
reserves := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(50e6)),
|
|
|
|
|
)
|
|
|
|
|
depositor := suite.CreateAccount(reserves)
|
|
|
|
|
pool := swap.NewAllowedPool(reserves[0].Denom, reserves[1].Denom)
|
|
|
|
|
suite.Require().NoError(pool.Validate())
|
|
|
|
|
suite.Keeper.SetParams(suite.Ctx, swap.NewParams(swap.NewAllowedPools(pool), swap.DefaultSwapFee))
|
|
|
|
|
|
|
|
|
|
err := suite.Keeper.Deposit(suite.Ctx, depositor.GetAddress(), reserves[0], reserves[1], sdk.MustNewDecFromStr("1"))
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
minTokenA := sdk.NewCoin("ukava", sdk.NewInt(4999999))
|
|
|
|
|
minTokenB := sdk.NewCoin("usdx", sdk.NewInt(24999998))
|
|
|
|
|
|
|
|
|
|
withdraw := swap.NewMsgWithdraw(
|
|
|
|
|
depositor.GetAddress(),
|
|
|
|
|
sdk.NewInt(11180339),
|
|
|
|
|
minTokenA,
|
|
|
|
|
minTokenB,
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
ctx := suite.App.NewContext(true, abci.Header{Height: 1, Time: tmtime.Now()})
|
|
|
|
|
res, err := suite.handler(ctx, withdraw)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
expectedCoinsReceived := sdk.NewCoins(minTokenA, minTokenB)
|
|
|
|
|
|
|
|
|
|
suite.AccountBalanceEqual(depositor, expectedCoinsReceived)
|
|
|
|
|
suite.ModuleAccountBalanceEqual(reserves.Sub(expectedCoinsReceived))
|
|
|
|
|
suite.PoolLiquidityEqual(reserves.Sub(expectedCoinsReceived))
|
|
|
|
|
suite.PoolShareValueEqual(depositor, swap.NewAllowedPool("ukava", "usdx"), reserves.Sub(expectedCoinsReceived))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
sdk.EventTypeMessage,
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, swap.AttributeValueCategory),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeySender, depositor.GetAddress().String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
bank.EventTypeTransfer,
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeyRecipient, depositor.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeySender, swapModuleAccountAddress.String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, expectedCoinsReceived.String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
swap.EventTypeSwapWithdraw,
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyPoolID, swap.PoolID(pool.TokenA, pool.TokenB)),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyOwner, depositor.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, expectedCoinsReceived.String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyShares, "11180339"),
|
|
|
|
|
))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestWithdraw_SlippageFailure() {
|
|
|
|
|
reserves := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(50e6)),
|
|
|
|
|
)
|
|
|
|
|
depositor := suite.CreateAccount(reserves)
|
|
|
|
|
pool := swap.NewAllowedPool(reserves[0].Denom, reserves[1].Denom)
|
|
|
|
|
suite.Require().NoError(pool.Validate())
|
|
|
|
|
suite.Keeper.SetParams(suite.Ctx, swap.NewParams(swap.NewAllowedPools(pool), swap.DefaultSwapFee))
|
|
|
|
|
|
|
|
|
|
err := suite.Keeper.Deposit(suite.Ctx, depositor.GetAddress(), reserves[0], reserves[1], sdk.MustNewDecFromStr("1"))
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
minTokenA := sdk.NewCoin("ukava", sdk.NewInt(5e6))
|
|
|
|
|
minTokenB := sdk.NewCoin("usdx", sdk.NewInt(25e6))
|
|
|
|
|
|
|
|
|
|
withdraw := swap.NewMsgWithdraw(
|
|
|
|
|
depositor.GetAddress(),
|
|
|
|
|
sdk.NewInt(11180339),
|
|
|
|
|
minTokenA,
|
|
|
|
|
minTokenB,
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
res, err := suite.handler(suite.Ctx, withdraw)
|
|
|
|
|
suite.EqualError(err, "slippage exceeded: minimum withdraw not met")
|
|
|
|
|
suite.Nil(res)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestWithdraw_DeadlineExceeded() {
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(50e6)),
|
|
|
|
|
)
|
|
|
|
|
from := suite.CreateAccount(balance)
|
|
|
|
|
|
|
|
|
|
withdraw := swap.NewMsgWithdraw(
|
|
|
|
|
from.GetAddress(),
|
|
|
|
|
sdk.NewInt(2e6),
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(1e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5e6)),
|
|
|
|
|
suite.Ctx.BlockTime().Add(-1*time.Second).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
res, err := suite.handler(suite.Ctx, withdraw)
|
|
|
|
|
suite.EqualError(err, fmt.Sprintf("deadline exceeded: block time %d >= deadline %d", suite.Ctx.BlockTime().Unix(), withdraw.GetDeadline().Unix()))
|
|
|
|
|
suite.Nil(res)
|
|
|
|
|
}
|
|
|
|
|
|
2021-07-13 22:44:05 +00:00
|
|
|
func (suite *handlerTestSuite) TestSwapExactForTokens() {
|
|
|
|
|
reserves := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(1000e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5000e6)),
|
|
|
|
|
)
|
|
|
|
|
err := suite.CreatePool(reserves)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
)
|
|
|
|
|
requester := suite.NewAccountFromAddr(sdk.AccAddress("requester"), balance)
|
|
|
|
|
|
|
|
|
|
swapInput := sdk.NewCoin("ukava", sdk.NewInt(1e6))
|
|
|
|
|
swapMsg := swap.NewMsgSwapExactForTokens(
|
|
|
|
|
requester.GetAddress(),
|
|
|
|
|
swapInput,
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5e6)),
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
ctx := suite.App.NewContext(true, abci.Header{Height: 1, Time: tmtime.Now()})
|
|
|
|
|
res, err := suite.handler(ctx, swapMsg)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
expectedSwapOutput := sdk.NewCoin("usdx", sdk.NewInt(4980034))
|
|
|
|
|
|
|
|
|
|
suite.AccountBalanceEqual(requester, balance.Sub(sdk.NewCoins(swapInput)).Add(expectedSwapOutput))
|
|
|
|
|
suite.ModuleAccountBalanceEqual(reserves.Add(swapInput).Sub(sdk.NewCoins(expectedSwapOutput)))
|
|
|
|
|
suite.PoolLiquidityEqual(reserves.Add(swapInput).Sub(sdk.NewCoins(expectedSwapOutput)))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
sdk.EventTypeMessage,
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, swap.AttributeValueCategory),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeySender, requester.GetAddress().String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
bank.EventTypeTransfer,
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeyRecipient, swapModuleAccountAddress.String()),
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeySender, requester.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, swapInput.String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
bank.EventTypeTransfer,
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeyRecipient, requester.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeySender, swapModuleAccountAddress.String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, expectedSwapOutput.String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
swap.EventTypeSwapTrade,
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyPoolID, swap.PoolID("ukava", "usdx")),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyRequester, requester.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeySwapInput, swapInput.String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeySwapOutput, expectedSwapOutput.String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyFeePaid, "3000ukava"),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyExactDirection, "input"),
|
|
|
|
|
))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestSwapExactForTokens_SlippageFailure() {
|
|
|
|
|
reserves := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(1000e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5000e6)),
|
|
|
|
|
)
|
|
|
|
|
err := suite.CreatePool(reserves)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(100e6)),
|
|
|
|
|
)
|
|
|
|
|
requester := suite.NewAccountFromAddr(sdk.AccAddress("requester"), balance)
|
|
|
|
|
|
|
|
|
|
swapInput := sdk.NewCoin("ukava", sdk.NewInt(1e6))
|
|
|
|
|
swapMsg := swap.NewMsgSwapExactForTokens(
|
|
|
|
|
requester.GetAddress(),
|
|
|
|
|
swapInput,
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5030338)),
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
ctx := suite.App.NewContext(true, abci.Header{Height: 1, Time: tmtime.Now()})
|
|
|
|
|
res, err := suite.handler(ctx, swapMsg)
|
|
|
|
|
suite.EqualError(err, "slippage exceeded: slippage 0.010000123252155223 > limit 0.010000000000000000")
|
|
|
|
|
suite.Nil(res)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestSwapExactForTokens_DeadlineExceeded() {
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
)
|
|
|
|
|
requester := suite.CreateAccount(balance)
|
|
|
|
|
|
|
|
|
|
swapMsg := swap.NewMsgSwapExactForTokens(
|
|
|
|
|
requester.GetAddress(),
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(5e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(25e5)),
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
suite.Ctx.BlockTime().Add(-1*time.Second).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
res, err := suite.handler(suite.Ctx, swapMsg)
|
|
|
|
|
suite.EqualError(err, fmt.Sprintf("deadline exceeded: block time %d >= deadline %d", suite.Ctx.BlockTime().Unix(), swapMsg.GetDeadline().Unix()))
|
|
|
|
|
suite.Nil(res)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestSwapForExactTokens() {
|
|
|
|
|
reserves := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(1000e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5000e6)),
|
|
|
|
|
)
|
|
|
|
|
err := suite.CreatePool(reserves)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
)
|
|
|
|
|
requester := suite.NewAccountFromAddr(sdk.AccAddress("requester"), balance)
|
|
|
|
|
|
|
|
|
|
swapOutput := sdk.NewCoin("usdx", sdk.NewInt(5e6))
|
|
|
|
|
swapMsg := swap.NewMsgSwapForExactTokens(
|
|
|
|
|
requester.GetAddress(),
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(1e6)),
|
|
|
|
|
swapOutput,
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
ctx := suite.App.NewContext(true, abci.Header{Height: 1, Time: tmtime.Now()})
|
|
|
|
|
res, err := suite.handler(ctx, swapMsg)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
expectedSwapInput := sdk.NewCoin("ukava", sdk.NewInt(1004015))
|
|
|
|
|
|
|
|
|
|
suite.AccountBalanceEqual(requester, balance.Sub(sdk.NewCoins(expectedSwapInput)).Add(swapOutput))
|
|
|
|
|
suite.ModuleAccountBalanceEqual(reserves.Add(expectedSwapInput).Sub(sdk.NewCoins(swapOutput)))
|
|
|
|
|
suite.PoolLiquidityEqual(reserves.Add(expectedSwapInput).Sub(sdk.NewCoins(swapOutput)))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
sdk.EventTypeMessage,
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyModule, swap.AttributeValueCategory),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeySender, requester.GetAddress().String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
bank.EventTypeTransfer,
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeyRecipient, swapModuleAccountAddress.String()),
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeySender, requester.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, expectedSwapInput.String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
bank.EventTypeTransfer,
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeyRecipient, requester.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(bank.AttributeKeySender, swapModuleAccountAddress.String()),
|
|
|
|
|
sdk.NewAttribute(sdk.AttributeKeyAmount, swapOutput.String()),
|
|
|
|
|
))
|
|
|
|
|
|
|
|
|
|
suite.EventsContains(res.Events, sdk.NewEvent(
|
|
|
|
|
swap.EventTypeSwapTrade,
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyPoolID, swap.PoolID("ukava", "usdx")),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyRequester, requester.GetAddress().String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeySwapInput, expectedSwapInput.String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeySwapOutput, swapOutput.String()),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyFeePaid, "3013ukava"),
|
|
|
|
|
sdk.NewAttribute(swap.AttributeKeyExactDirection, "output"),
|
|
|
|
|
))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestSwapForExactTokens_SlippageFailure() {
|
|
|
|
|
reserves := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(1000e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(5000e6)),
|
|
|
|
|
)
|
|
|
|
|
err := suite.CreatePool(reserves)
|
|
|
|
|
suite.Require().NoError(err)
|
|
|
|
|
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
)
|
|
|
|
|
requester := suite.NewAccountFromAddr(sdk.AccAddress("requester"), balance)
|
|
|
|
|
|
|
|
|
|
swapOutput := sdk.NewCoin("usdx", sdk.NewInt(5e6))
|
|
|
|
|
swapMsg := swap.NewMsgSwapForExactTokens(
|
|
|
|
|
requester.GetAddress(),
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(990991)),
|
|
|
|
|
swapOutput,
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
time.Now().Add(10*time.Minute).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
ctx := suite.App.NewContext(true, abci.Header{Height: 1, Time: tmtime.Now()})
|
|
|
|
|
res, err := suite.handler(ctx, swapMsg)
|
|
|
|
|
suite.EqualError(err, "slippage exceeded: slippage 0.010000979019022939 > limit 0.010000000000000000")
|
|
|
|
|
suite.Nil(res)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func (suite *handlerTestSuite) TestSwapForExactTokens_DeadlineExceeded() {
|
|
|
|
|
balance := sdk.NewCoins(
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(10e6)),
|
|
|
|
|
)
|
|
|
|
|
requester := suite.CreateAccount(balance)
|
|
|
|
|
|
|
|
|
|
swapMsg := swap.NewMsgSwapForExactTokens(
|
|
|
|
|
requester.GetAddress(),
|
|
|
|
|
sdk.NewCoin("ukava", sdk.NewInt(5e6)),
|
|
|
|
|
sdk.NewCoin("usdx", sdk.NewInt(25e5)),
|
|
|
|
|
sdk.MustNewDecFromStr("0.01"),
|
|
|
|
|
suite.Ctx.BlockTime().Add(-1*time.Second).Unix(),
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
res, err := suite.handler(suite.Ctx, swapMsg)
|
|
|
|
|
suite.EqualError(err, fmt.Sprintf("deadline exceeded: block time %d >= deadline %d", suite.Ctx.BlockTime().Unix(), swapMsg.GetDeadline().Unix()))
|
|
|
|
|
suite.Nil(res)
|
|
|
|
|
}
|
|
|
|
|
|
Squash merge swap-acceptance branch (#956)
* add failing acceptance test for a user depositing into a pool
* implement GetAccount test helper
* implement swap.MsgDeposit for creating and adding liquidity to a pool
* update aliases, add event types, and fix typo/compiler errors in handler
test
* use only aliases names in handler test (don't use swap types -- ensures
we have run aliasgen), add assertion for even type message
* implement account and module account balance checks in handler test
* fill out handler assertions for testing keeper state and events
* update signed json representation and register swap/MsgDeposit for
proper encoding
* fill out boilerplate to get handler test to compile
* alias gen for pool
* add handling of message type; fill in deposit keeper method for
succesful compile; noop but test assertions now run up to module acc not
nil check
* add module account permissions for swap module -- fixes module account
creation; pass account keeper and supply keeper into swap keeper to
allow the ability to work with user and module accounts
* implement create pool logic for msg deposit; allows creation of a of new
pool, checking params to see if it is allowed. Initi shares are set,
and senders number of shares are stored
* Swap migrations scaffolding (#925)
* swap module scaffolding
* global swap fee
* can't think of a reason for begin blocker; removing for abci.go for now;
* test pair types; refactor pair name logic; simplify pairs validation and
fix stack overflow error
* check comparison
* use test package
* init swap module genesis
* add basic marshall tests
* remove reward apy from pairs
* fix integration helpers
* use max swap fee constant; fix validation of swap fee; add tests to
cover param validation and param set setup
* use noerror over nil
* start genesis tests
* test param set validation mirrors param validation
* add genesis tests
* remove print statement
* add subtests for genesis test cases; add extra querier test for unknown
route; add keeper params testing
* add spec
* update swagger
* find replace hard -> swap in comments
* remove unused method
* rename pairs to allowed pools; pool is more commonly used, and
allowedPool makes it more clear what swap parameter is for. In
addition, we won't conflict with Pool data structure for storing a
created pool in the store.
* remove generated link
* missed spec rename
* validate token order for allowed pools
* fix swagger
* json should be snakecase; change allowedPools to allowed_pools
* add legacy types
* add swap genesis to v0_15 migration
* add legacy types
* add swap genesis to v0_15 migration
* migration revisions
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
* keeper todos
* update keeper tests
* type todos
* update types tests
* tx deposit cli cmd
* tx deposit rest
* Swap module simulation scaffolding (#924)
* sims scaffolding
* add noop operation
* genesis revisions
* add param changes
* mvoe persistance methods to main keeper file, consolidate tests
* make helper methods private. they are tested via deposit method, and
unit testing them would make test suite brittle and refactoring
difficult
* use more clear coin variables
* code 1 is reserved, use code 2 and sequence all errors
* remove todo
* Implement deadline for swap module module message. This is implemented in
handler with a interface to easily apply to it to all messages, and
separate msg validation concerns from the keeper
* move allowed pools to params -- let pool and pool_test focus on pool domain logic, not
parameter & governance concerns
* update alias
* add unitless implementatin of constant product liquidity pool to
isolate and enapsulate liquidity logic. Swap methods interfaces are
added, but implementation not yet added
* nits and todos
* add ErrInvalidPool
* add tests for edge cases around pool depletion; add explicit panic for
edge case that results in a pool reserve being zero; handle pool
reinitialization if it is empty
* touch up comments and flush out the rest of assertions
* add data structures for keeper state storage separate from pool domain
objects, and improve structure for easier querying
* rename pool name to pool key for events
* add support for a denominated pool that uses sdk.Coins and sdk.Coin
arguments, keeping tracking of the units in the base pool. This gives
nice separation between pool logic, and coin/denom logic
* refactor keeper to use new records for storage, and implement pool
deposit using the denominated pool
* address previous PR comment - reminder for migration if changing
account permissions
* msg deposit should validate that denoms are not equal
* add godoc comments
* golint and some poolName -> poolID cleanup
* implement adding liquidity to an existing pool
* hardcode pools in sims
* touch up comment
* withdraw keeper logic
* withdraw type updates
* add withdraw msg tx handler
* initial withdraw test
* fix panic
* use new denominated pool with existing shares
* fix: check args on deposit cmd
* add slippage limit check for depositing to an existing pool
* send coins just before event emission
* check liquidity returned is greater than zero for both coins; ensure
returned number of shares are greater than zero
* add deadline to msgwithdraw
* register msgwithdraw
* scaffold msgwithdraw types test
* register the correct msg
* modify swap functions to also return the amount paid for the pool swap
fee. This will be used to calculate slippage and for event tracking
* add slippage types
* add expected withdrawal coins
* calculate slippage against expected coins
* update withdraw keeper tests
* spelling, improve comments on add liquidity math
* typo
* typo
* grammer
* typo / grammer
* remove pool_id from withdraw msg
* add slippage to tx cmd
* TestWithdraw_Partial
* nit
* add withdraw no pool, no deposit record tests
* drop event check on partial withdraw test
* fix broken link
* fix broken link
* resolve merge conflicts
* ensure swap fee can not be equal to 1; add full implementation of swap
pool methods; these implementation ensure that the pool invariant is
always greater or equal to the previous invariant
* refactor duplicated code into private swap methods
* add runtime assertion to always ensure invariant is greater or equal
to the previous invariant sub fee on swaps
* improve comments for base pool swap functions
* add swap exact input and output methods to denominated pool that wrap
the base pool interface for swapping
* comment touch ups
* more comment touchups
* fix msg deposit struct tag (#943)
* use better name for swap calculation private methods
* nits: golint
* fix misspelling in method name
* Add HARD token governance committee for Hard module (#941)
* add hard gov token committee
* revisions: update migration
* revisions: update test/data file
* initial revisions
* add TokenCommittee JSONMarshal test
* fix SetPermissions method
* remove BaseCommittee Type field
* add incentive params to allowed params
* Add SWP token governance committee for Swap module (#946)
* add swp token commitee to migration
* update test, add gen export utility method
* final revisions: add TODO
* remove slippage from withdraw to use min values for coins; add
additional validation test cases
* update alias for swap module
* add withdraw tests to handler for increased coverage; note: first pass,
improvements still yet to be made here
* refact withdraw keeper to use min amounts; panic for cases that do not
happen in normal situations
* lint fixes
* use total shares to track if pool should be deleted; add more in depth
withdraw comment
* add exact args for withdraw cmd
* extract record update methods
* update depositor share record if it exists -- do not overwrite an
existing record; ensures no loss of shares if the same address deposits
more than once
* Swap queries: deposit, pool, pools (#949)
* query deposits types
* implement deposit querier keeper methods
* query deposits CLI
* query deposits REST
* query types for pool/pools
* pool/pools querier keeper methods
* pool/pools CLI
* pool/pools REST
* basic pool/pools query tests
* basic deposit querier test
* iterate share records via owner bytes
* nit: add example for querying deposits by owner only
Co-authored-by: karzak <kjydavis3@gmail.com>
* feat: add REST tx handler for swap LP withdrawals
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: Denali Marsh <denali@kava.io>
Co-authored-by: denalimarsh <denalimarsh@gmail.com>
Co-authored-by: karzak <kjydavis3@gmail.com>
2021-07-13 11:38:15 +00:00
|
|
|
func (suite *handlerTestSuite) TestInvalidMsg() {
|
|
|
|
|
res, err := suite.handler(suite.Ctx, sdk.NewTestMsg())
|
|
|
|
|
suite.Nil(res)
|
|
|
|
|
suite.EqualError(err, "unknown request: unrecognized swap message type: *types.TestMsg")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestHandlerTestSuite(t *testing.T) {
|
|
|
|
|
suite.Run(t, new(handlerTestSuite))
|
|
|
|
|
}
|