0g-chain/x/evmutil/keeper/msg_server_test.go

495 lines
14 KiB
Go
Raw Normal View History

package keeper_test
import (
"math/big"
"testing"
"github.com/stretchr/testify/suite"
sdkmath "cosmossdk.io/math"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/common/math"
"github.com/kava-labs/kava/app"
"github.com/kava-labs/kava/x/evmutil/keeper"
"github.com/kava-labs/kava/x/evmutil/testutil"
"github.com/kava-labs/kava/x/evmutil/types"
)
type MsgServerSuite struct {
testutil.Suite
msgServer types.MsgServer
}
func (suite *MsgServerSuite) SetupTest() {
suite.Suite.SetupTest()
suite.msgServer = keeper.NewMsgServerImpl(suite.App.GetEvmutilKeeper())
}
func TestMsgServerSuite(t *testing.T) {
suite.Run(t, new(MsgServerSuite))
}
func (suite *MsgServerSuite) TestConvertCoinToERC20() {
invoker, err := sdk.AccAddressFromBech32("kava123fxg0l602etulhhcdm0vt7l57qya5wjcrwhzz")
suite.Require().NoError(err)
err = suite.App.FundAccount(suite.Ctx, invoker, sdk.NewCoins(sdk.NewCoin("erc20/usdc", sdkmath.NewInt(10000))))
suite.Require().NoError(err)
contractAddr := suite.DeployERC20()
pair := types.NewConversionPair(
contractAddr,
"erc20/usdc",
)
// Module account should have starting balance
pairStartingBal := big.NewInt(10000)
err = suite.Keeper.MintERC20(
suite.Ctx,
pair.GetAddress(), // contractAddr
types.NewInternalEVMAddress(types.ModuleEVMAddress), //receiver
pairStartingBal,
)
suite.Require().NoError(err)
type errArgs struct {
expectPass bool
contains string
}
tests := []struct {
name string
msg types.MsgConvertCoinToERC20
errArgs errArgs
}{
{
"valid",
types.NewMsgConvertCoinToERC20(
invoker.String(),
"0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2",
sdk.NewCoin("erc20/usdc", sdkmath.NewInt(1234)),
),
errArgs{
expectPass: true,
},
},
{
"invalid - odd length hex address",
types.NewMsgConvertCoinToERC20(
invoker.String(),
"0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc",
sdk.NewCoin("erc20/usdc", sdkmath.NewInt(1234)),
),
errArgs{
expectPass: false,
contains: "invalid Receiver address: string is not a hex address",
},
},
// Amount coin is not validated by msg_server, but on msg itself
}
for _, tc := range tests {
suite.Run(tc.name, func() {
_, err := suite.msgServer.ConvertCoinToERC20(sdk.WrapSDKContext(suite.Ctx), &tc.msg)
if tc.errArgs.expectPass {
suite.Require().NoError(err)
bal := suite.GetERC20BalanceOf(
types.ERC20MintableBurnableContract.ABI,
pair.GetAddress(),
testutil.MustNewInternalEVMAddressFromString(tc.msg.Receiver),
)
suite.Require().Equal(tc.msg.Amount.Amount.BigInt(), bal, "balance should match converted amount")
// msg server event
suite.EventsContains(suite.GetEvents(),
sdk.NewEvent(
sdk.EventTypeMessage,
sdk.NewAttribute(sdk.AttributeKeyModule, types.AttributeValueCategory),
sdk.NewAttribute(sdk.AttributeKeySender, tc.msg.Initiator),
))
// keeper event
suite.EventsContains(suite.GetEvents(),
sdk.NewEvent(
types.EventTypeConvertCoinToERC20,
sdk.NewAttribute(types.AttributeKeyInitiator, tc.msg.Initiator),
sdk.NewAttribute(types.AttributeKeyReceiver, tc.msg.Receiver),
sdk.NewAttribute(types.AttributeKeyERC20Address, pair.GetAddress().String()),
sdk.NewAttribute(types.AttributeKeyAmount, tc.msg.Amount.String()),
))
} else {
suite.Require().Error(err)
suite.Require().Contains(err.Error(), tc.errArgs.contains)
}
})
}
}
func (suite *MsgServerSuite) TestConvertERC20ToCoin() {
contractAddr := suite.DeployERC20()
pair := types.NewConversionPair(
contractAddr,
"erc20/usdc",
)
// give invoker account some erc20 usdc to begin with
invoker := testutil.MustNewInternalEVMAddressFromString("0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2")
pairStartingBal := big.NewInt(10_000_000)
err := suite.Keeper.MintERC20(
suite.Ctx,
pair.GetAddress(), // contractAddr
invoker, //receiver
pairStartingBal,
)
suite.Require().NoError(err)
feat: upgrade to Cosmos v0.46 (#1477) * Update cosmos-sdk to v0.45.10-kava * Add RegisterNodeService to app * Update cosmos proto files * Update cosmos proto files * Use tagged v0.45.10-kava-v0.19-0.21 cosmos version * update x/auth/legacy to x/auth/migrations * Delete rest packages and registration * Remove rest from proposal handlers * Remove legacy types referencing removed sdk types * Remove legacy tx broadcast handler * Update incentive staking hooks to return error * Remove grpc replace directive, use new grpc version * Fix storetypes import * Update tally_handler with updated gov types * Delete legacy types * Use new gov default config * Update RegisterTendermintService params Signed-off-by: drklee3 <derrick@dlee.dev> * Replace sdk.StoreKey with storetypes.StoreKey * Replace sdk.Int#ToDec with sdk.NewDecFromInt * Replace sdk.NewUintFromBigInt with sdkmath.NewUintFromBigInt Signed-off-by: drklee3 <derrick@dlee.dev> * Update most intances of govtypes to govv1beta1 * Unpack coin slice for Coins#Sub and Coins#SafeSub Signed-off-by: drklee3 <derrick@dlee.dev> * Update committee gov codec registration Signed-off-by: drklee3 <derrick@dlee.dev> * Update migrate utils period_vesting Coins#Sub Signed-off-by: drklee3 <derrick@dlee.dev> * Update Coin#Sub in community proposal handler Signed-off-by: drklee3 <derrick@dlee.dev> * Update Coin#Sub, FundModuleAccount/FundAccount in banktestutil Signed-off-by: drklee3 <derrick@dlee.dev> * Update community, earn, kavadist proposal gov registration * Update evm cli client EthSecp256k1Type check * AccAddressFromHex to AccAddressFromHexUnsafe * Add mint DefaultInflationCalculationFn to earn test * Update use of removed staking.NewHandler * Rename FlagIAVLFastNode -> FlagDisableIAVLFastNode * cmd: Update new snapshot app option Signed-off-by: drklee3 <derrick@dlee.dev> * cmd: Add tendermint default config, use cosmos rpc status command Signed-off-by: drklee3 <derrick@dlee.dev> * Update ethermint import path github.com/tharsis/ethermint -> github.com/evmos/ethermint * Upgrade ibc-go to v6 * Update proto dependencies Signed-off-by: drklee3 <derrick@dlee.dev> * Update Tally handler test with new gov types * Update helpers.GenTx -> helpers.GenSignedMockTx * Update evmkeeper.NewKeeper params Signed-off-by: drklee3 <derrick@dlee.dev> * Update ante authz, tests * Add feemarket transient key, pass subspaces to evm/feemarket keepers * Update new ante decorators * Add new addModuleInitFlags to server commands * Pass codec to keyring.New in genaccounts * Pass codec to client keys add * Add SendCoins to evmutil bank_keeper * Use github.com/cosmos/iavl@v0.19.5 * Add ante HandlerOptions * Add unimplemented SendCoins to evmutil bank keeper Ethermint x/evm does not use this method * Update init-new-chain script to disable post-london blocks * Modify test genesis states to append 1 validator * Update tally handler test to use string values * Prevent querying balance for empty sdk.AccAddress in auction bidding test * Set default bond denom to ukava * Remove overwritten bank genesis total supply in committee proposal test Signed-off-by: drklee3 <derrick@dlee.dev> * Use ukava for testing staked balance * Disable minting in community proposal handler test Previously stake denom is used, which resulted in 0 minted coins * Update hard APYToSPY test expected value Increased iterations in sdk.ApproxRoot, updated closer to real value * Fix NewDecCoinsFromCoins bug in incentive collectDerivativeStakingRewards * Allow bkava earn incentive test values to match within small margin for rounding Signed-off-by: drklee3 <derrick@dlee.dev> * Update invalid denom in issuance message coin validation Colons are now valid in denoms Signed-off-by: drklee3 <derrick@dlee.dev> * Remove genesis validator in incentive delegation tests * Update pricefeed market test for invalid denom Signed-off-by: drklee3 <derrick@dlee.dev> * Update incentive delegator rewards test without genesis validator Signed-off-by: drklee3 <derrick@dlee.dev> * Add validator to export test * Clear bank state in minting tests Signed-off-by: drklee3 <derrick@dlee.dev> * Remove validator for no stake tally test Signed-off-by: drklee3 <derrick@dlee.dev> * Clear incentive state before InitGenesis in incentive genesis export test * Update swagger Signed-off-by: drklee3 <derrick@dlee.dev> * Update ethermint version to match replaced version * Remove legacy swagger * Add NewEthEmitEventDecorator * Remove redundant func for AddModuleInitFlags * Remove unused addBankBalanceForAddress func * Add SetIAVLLazyLoading option to app cmd * Use legacy.RegisterAminoMsg for committee msg concrete registration * Remove unnecessary Amino field * Add evm_util bankkeeper SendCoins comment * Update test method ResetBankState to DeleteGenesisValidatorCoins to be more clear * Validate incentive params.RewardsPerSecond to be non-zero * Validate swap pools to disallow colons in token denoms * Register all legacy amino types on gov modulecdc * Remove redundant Comittee interface registration * Pin goleveldb to v1.0.1-0.20210819022825-2ae1ddf74ef7 Causes failed to load state at height errors * Update ethermint to new pinned version with minGasPrices parse error fix * Update cosmos fork dependcy commit to include reverted account constructor patch * Update Cosmos v0.46.11 and cometbft v0.34.27 * Bump minimum go version to 1.19 * Update tendermint proto * Update internal testnet genesis * Move NewCanTransferDecorator before NewEthGasConsumeDecorator * Add hard borrow store tests (#1514) * add store tests for Borrow type * refactor Deposit tests to match * Fix old bep3 tests (#1515) * Update Ethermint to 1b17445 to fix duplicate proto registration * Add custom status command to use snake_case and stdout * Add SetInflation helper * Reduce ambiguity with evm CanSignEthTx error * Remove init genesis validator claim in test * Add disabled evmante.NewMinGasPriceDecorator with x/feemarket note * chore: use tagged versions for Cosmos and Ethermint forks * update kvtool & increase wait for ibc transfer test --------- Signed-off-by: drklee3 <derrick@dlee.dev> Co-authored-by: Ruaridh <rhuairahrighairidh@users.noreply.github.com> Co-authored-by: Robert Pirtle <astropirtle@gmail.com>
2023-04-04 00:08:45 +00:00
invokerCosmosAddr, err := sdk.AccAddressFromHexUnsafe(invoker.String()[2:])
suite.Require().NoError(err)
// create user account, otherwise `CallEVMWithData` will fail due to failing to get user account when finding its sequence.
err = suite.App.FundAccount(suite.Ctx, invokerCosmosAddr, sdk.NewCoins(sdk.NewCoin(pair.Denom, sdk.ZeroInt())))
suite.Require().NoError(err)
type errArgs struct {
expectPass bool
contains string
}
tests := []struct {
name string
msg types.MsgConvertERC20ToCoin
approvalAmount *big.Int
errArgs errArgs
}{
{
"valid",
types.NewMsgConvertERC20ToCoin(
invoker,
invokerCosmosAddr,
contractAddr,
sdkmath.NewInt(10_000),
),
math.MaxBig256,
errArgs{
expectPass: true,
},
},
{
"invalid - invalid hex address",
types.MsgConvertERC20ToCoin{
Initiator: "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc",
Receiver: invokerCosmosAddr.String(),
KavaERC20Address: contractAddr.String(),
Amount: sdkmath.NewInt(10_000),
},
math.MaxBig256,
errArgs{
expectPass: false,
contains: "invalid initiator address: string is not a hex address",
},
},
{
"invalid - insufficient coins",
types.NewMsgConvertERC20ToCoin(
invoker,
invokerCosmosAddr,
contractAddr,
sdkmath.NewIntFromBigInt(pairStartingBal).Add(sdk.OneInt()),
),
math.MaxBig256,
errArgs{
expectPass: false,
contains: "transfer amount exceeds balance",
},
},
{
"invalid - contract address",
types.NewMsgConvertERC20ToCoin(
invoker,
invokerCosmosAddr,
testutil.MustNewInternalEVMAddressFromString("0x7Bbf300890857b8c241b219C6a489431669b3aFA"),
sdkmath.NewInt(10_000),
),
math.MaxBig256,
errArgs{
expectPass: false,
contains: "ERC20 token not enabled to convert to sdk.Coin",
},
},
}
for _, tc := range tests {
suite.Run(tc.name, func() {
_, err := suite.msgServer.ConvertERC20ToCoin(sdk.WrapSDKContext(suite.Ctx), &tc.msg)
if tc.errArgs.expectPass {
suite.Require().NoError(err)
// validate user balance after conversion
bal := suite.GetERC20BalanceOf(
types.ERC20MintableBurnableContract.ABI,
pair.GetAddress(),
testutil.MustNewInternalEVMAddressFromString(tc.msg.Initiator),
)
expectedBal := sdkmath.NewIntFromBigInt(pairStartingBal).Sub(tc.msg.Amount)
suite.Require().Equal(expectedBal.BigInt(), bal, "user erc20 balance is invalid")
// validate user coin balance
coinBal := suite.App.GetBankKeeper().GetBalance(suite.Ctx, invokerCosmosAddr, pair.Denom)
suite.Require().Equal(tc.msg.Amount, coinBal.Amount, "user coin balance is invalid")
// msg server event
suite.EventsContains(suite.GetEvents(),
sdk.NewEvent(
sdk.EventTypeMessage,
sdk.NewAttribute(sdk.AttributeKeyModule, types.AttributeValueCategory),
sdk.NewAttribute(sdk.AttributeKeySender, tc.msg.Initiator),
))
// keeper event
suite.EventsContains(suite.GetEvents(),
sdk.NewEvent(
types.EventTypeConvertERC20ToCoin,
sdk.NewAttribute(types.AttributeKeyERC20Address, pair.GetAddress().String()),
sdk.NewAttribute(types.AttributeKeyInitiator, tc.msg.Initiator),
sdk.NewAttribute(types.AttributeKeyReceiver, tc.msg.Receiver),
sdk.NewAttribute(types.AttributeKeyAmount, sdk.NewCoin(pair.Denom, tc.msg.Amount).String()),
))
} else {
suite.Require().Error(err)
suite.Require().Contains(err.Error(), tc.errArgs.contains)
}
})
}
}
func (suite *MsgServerSuite) TestConvertCosmosCoinToERC20_InitialContractDeploy() {
allowedDenom := "ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2"
initialFunding := int64(1e10)
fundedAccount := app.RandomAddress()
setup := func() {
suite.SetupTest()
// make the denom allowed for conversion
params := suite.Keeper.GetParams(suite.Ctx)
params.AllowedCosmosDenoms = types.NewAllowedCosmosCoinERC20Tokens(
types.NewAllowedCosmosCoinERC20Token(allowedDenom, "Kava EVM Atom", "ATOM", 6),
)
suite.Keeper.SetParams(suite.Ctx, params)
// fund account
err := suite.App.FundAccount(suite.Ctx, fundedAccount, sdk.NewCoins(
sdk.NewInt64Coin(allowedDenom, initialFunding),
))
suite.NoError(err, "failed to initially fund account")
}
testCases := []struct {
name string
msg types.MsgConvertCosmosCoinToERC20
amountConverted sdkmath.Int
expectedErr string
}{
{
name: "valid - first conversion deploys contract, send to self",
msg: types.NewMsgConvertCosmosCoinToERC20(
fundedAccount.String(),
common.BytesToAddress(fundedAccount.Bytes()).Hex(), // it's me!
sdk.NewInt64Coin(allowedDenom, 5e7),
),
amountConverted: sdkmath.NewInt(5e7),
expectedErr: "",
},
{
name: "valid - first conversion deploys contract, send to other",
msg: types.NewMsgConvertCosmosCoinToERC20(
fundedAccount.String(),
testutil.RandomEvmAddress().Hex(), // someone else!
sdk.NewInt64Coin(allowedDenom, 9993317),
),
amountConverted: sdkmath.NewInt(9993317),
expectedErr: "",
},
{
name: "invalid - un-allowed denom",
msg: types.NewMsgConvertCosmosCoinToERC20(
app.RandomAddress().String(),
testutil.RandomEvmAddress().Hex(),
sdk.NewInt64Coin("not-allowed-denom", 1e4),
),
expectedErr: "sdk.Coin not enabled to convert to ERC20 token",
},
{
name: "invalid - bad initiator",
msg: types.NewMsgConvertCosmosCoinToERC20(
"invalid-kava-address",
testutil.RandomEvmAddress().Hex(),
sdk.NewInt64Coin(allowedDenom, 1e4),
),
expectedErr: "invalid initiator address",
},
{
name: "invalid - bad receiver",
msg: types.NewMsgConvertCosmosCoinToERC20(
app.RandomAddress().String(),
"invalid-0x-address",
sdk.NewInt64Coin(allowedDenom, 1e4),
),
expectedErr: "invalid receiver address",
},
{
name: "invalid - bad receiver",
msg: types.NewMsgConvertCosmosCoinToERC20(
app.RandomAddress().String(),
"invalid-0x-address",
sdk.NewInt64Coin(allowedDenom, 1e4),
),
expectedErr: "invalid receiver address",
},
{
name: "invalid - insufficient balance",
msg: types.NewMsgConvertCosmosCoinToERC20(
fundedAccount.String(),
testutil.RandomEvmAddress().Hex(),
sdk.NewInt64Coin(allowedDenom, initialFunding+1),
),
expectedErr: "insufficient funds",
},
// NOTE: a zero amount tx passes in this scope but will fail to pass ValidateBasic()
}
for _, tc := range testCases {
suite.Run(tc.name, func() {
// initial setup
setup()
moduleBalanceBefore := suite.ModuleBalance(allowedDenom)
// submit message
_, err := suite.msgServer.ConvertCosmosCoinToERC20(suite.Ctx, &tc.msg)
// verify error, if expected
if tc.expectedErr != "" {
suite.ErrorContains(err, tc.expectedErr)
// the contract wasn't previously deployed, so still shouldn't be
_, found := suite.Keeper.GetDeployedCosmosCoinContract(suite.Ctx, allowedDenom)
suite.False(found)
return
}
// verify success
suite.NoError(err)
suite.Commit()
initiator := sdk.MustAccAddressFromBech32(tc.msg.Initiator)
receiver := testutil.MustNewInternalEVMAddressFromString(tc.msg.Receiver)
// initiator no longer has sdk coins
cosmosBalanceAfter := suite.BankKeeper.GetBalance(suite.Ctx, initiator, allowedDenom)
suite.Equal(
sdkmath.NewInt(initialFunding).Sub(tc.amountConverted),
cosmosBalanceAfter.Amount,
"unexpected sdk.Coin balance of initiator",
)
// sdk coins are locked into module
moduleBalanceAfter := suite.ModuleBalance(allowedDenom)
suite.Equal(
moduleBalanceBefore.Add(tc.amountConverted),
moduleBalanceAfter,
"unexpected module balance",
)
// deployed contract address is registered in module store
contractAddress, found := suite.Keeper.GetDeployedCosmosCoinContract(suite.Ctx, allowedDenom)
suite.True(found, "expected deployed contract address to be registered, found none")
// receiver has been minted correct number of tokens
erc20Balance, err := suite.Keeper.QueryERC20BalanceOf(suite.Ctx, contractAddress, receiver)
suite.NoError(err)
suite.Equal(tc.amountConverted.BigInt(), erc20Balance, "unexpected erc20 balance for receiver")
})
}
}
func (suite *MsgServerSuite) TestConvertCosmosCoinToERC20_AlreadyDeployedContract() {
allowedDenom := "ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2"
initialFunding := int64(1e10)
fundedAccount := app.RandomAddress()
amount := sdkmath.NewInt(6e8)
receiver1 := types.BytesToInternalEVMAddress(app.RandomAddress().Bytes())
receiver2 := types.BytesToInternalEVMAddress(app.RandomAddress().Bytes())
suite.SetupTest()
// make the denom allowed for conversion
params := suite.Keeper.GetParams(suite.Ctx)
params.AllowedCosmosDenoms = types.NewAllowedCosmosCoinERC20Tokens(
types.NewAllowedCosmosCoinERC20Token(allowedDenom, "Kava EVM Atom", "ATOM", 6),
)
suite.Keeper.SetParams(suite.Ctx, params)
// fund account
err := suite.App.FundAccount(suite.Ctx, fundedAccount, sdk.NewCoins(
sdk.NewInt64Coin(allowedDenom, initialFunding),
))
suite.NoError(err, "failed to initially fund account")
// verify contract is not deployed
_, found := suite.Keeper.GetDeployedCosmosCoinContract(suite.Ctx, allowedDenom)
suite.False(found)
// initial convert deploys contract
msg := types.NewMsgConvertCosmosCoinToERC20(
fundedAccount.String(),
receiver1.Hex(),
sdk.NewCoin(allowedDenom, amount),
)
_, err = suite.msgServer.ConvertCosmosCoinToERC20(suite.Ctx, &msg)
suite.NoError(err)
contractAddress, found := suite.Keeper.GetDeployedCosmosCoinContract(suite.Ctx, allowedDenom)
suite.True(found)
// second convert uses same contract
msg.Receiver = receiver2.Hex()
_, err = suite.msgServer.ConvertCosmosCoinToERC20(suite.Ctx, &msg)
suite.NoError(err)
after2ndUseAddress, found := suite.Keeper.GetDeployedCosmosCoinContract(suite.Ctx, allowedDenom)
suite.True(found)
suite.Equal(contractAddress, after2ndUseAddress, "contract address should remain the same")
// check balances
bal1, err := suite.Keeper.QueryERC20BalanceOf(suite.Ctx, contractAddress, receiver1)
suite.NoError(err)
suite.Equal(amount.BigInt(), bal1)
bal2, err := suite.Keeper.QueryERC20BalanceOf(suite.Ctx, contractAddress, receiver2)
suite.NoError(err)
suite.Equal(amount.BigInt(), bal2)
// check total supply
caller, key := testutil.RandomEvmAccount()
totalSupply, err := suite.QueryContract(
types.ERC20KavaWrappedCosmosCoinContract.ABI,
caller,
key,
contractAddress,
"totalSupply",
)
suite.NoError(err)
suite.Len(totalSupply, 1)
suite.Equal(amount.MulRaw(2).BigInt(), totalSupply[0].(*big.Int))
}