2019-06-20 13:37:57 +00:00
|
|
|
package app
|
|
|
|
|
|
|
|
import (
|
|
|
|
"encoding/json"
|
|
|
|
"fmt"
|
2020-09-01 15:33:12 +00:00
|
|
|
"io/ioutil"
|
|
|
|
"math/rand"
|
2019-06-20 13:37:57 +00:00
|
|
|
"os"
|
|
|
|
"testing"
|
2020-09-01 15:33:12 +00:00
|
|
|
"time"
|
2019-06-20 13:37:57 +00:00
|
|
|
|
2020-04-30 14:23:41 +00:00
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
|
2020-05-04 21:17:20 +00:00
|
|
|
abci "github.com/tendermint/tendermint/abci/types"
|
|
|
|
"github.com/tendermint/tendermint/libs/log"
|
|
|
|
dbm "github.com/tendermint/tm-db"
|
|
|
|
|
2019-06-20 13:37:57 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/baseapp"
|
2020-09-01 15:33:12 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/codec"
|
2019-09-11 22:33:20 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
2020-04-23 16:35:58 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/simapp/helpers"
|
2019-09-11 22:33:20 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/store"
|
2019-06-20 13:37:57 +00:00
|
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
2020-09-01 15:33:12 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/types/module"
|
2019-09-11 22:33:20 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/x/auth"
|
|
|
|
distr "github.com/cosmos/cosmos-sdk/x/distribution"
|
|
|
|
"github.com/cosmos/cosmos-sdk/x/gov"
|
|
|
|
"github.com/cosmos/cosmos-sdk/x/mint"
|
|
|
|
"github.com/cosmos/cosmos-sdk/x/params"
|
2019-06-20 13:37:57 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/x/simulation"
|
2019-09-11 22:33:20 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/x/slashing"
|
2019-06-20 13:37:57 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/x/staking"
|
2019-09-11 22:33:20 +00:00
|
|
|
"github.com/cosmos/cosmos-sdk/x/supply"
|
2020-04-30 14:23:41 +00:00
|
|
|
|
2020-04-29 14:10:41 +00:00
|
|
|
"github.com/kava-labs/kava/x/auction"
|
|
|
|
"github.com/kava-labs/kava/x/bep3"
|
|
|
|
"github.com/kava-labs/kava/x/cdp"
|
2020-05-04 21:17:20 +00:00
|
|
|
"github.com/kava-labs/kava/x/committee"
|
2020-04-29 14:10:41 +00:00
|
|
|
"github.com/kava-labs/kava/x/incentive"
|
|
|
|
"github.com/kava-labs/kava/x/kavadist"
|
|
|
|
"github.com/kava-labs/kava/x/pricefeed"
|
Squash merge swap-acceptance branch (#956)
* add failing acceptance test for a user depositing into a pool
* implement GetAccount test helper
* implement swap.MsgDeposit for creating and adding liquidity to a pool
* update aliases, add event types, and fix typo/compiler errors in handler
test
* use only aliases names in handler test (don't use swap types -- ensures
we have run aliasgen), add assertion for even type message
* implement account and module account balance checks in handler test
* fill out handler assertions for testing keeper state and events
* update signed json representation and register swap/MsgDeposit for
proper encoding
* fill out boilerplate to get handler test to compile
* alias gen for pool
* add handling of message type; fill in deposit keeper method for
succesful compile; noop but test assertions now run up to module acc not
nil check
* add module account permissions for swap module -- fixes module account
creation; pass account keeper and supply keeper into swap keeper to
allow the ability to work with user and module accounts
* implement create pool logic for msg deposit; allows creation of a of new
pool, checking params to see if it is allowed. Initi shares are set,
and senders number of shares are stored
* Swap migrations scaffolding (#925)
* swap module scaffolding
* global swap fee
* can't think of a reason for begin blocker; removing for abci.go for now;
* test pair types; refactor pair name logic; simplify pairs validation and
fix stack overflow error
* check comparison
* use test package
* init swap module genesis
* add basic marshall tests
* remove reward apy from pairs
* fix integration helpers
* use max swap fee constant; fix validation of swap fee; add tests to
cover param validation and param set setup
* use noerror over nil
* start genesis tests
* test param set validation mirrors param validation
* add genesis tests
* remove print statement
* add subtests for genesis test cases; add extra querier test for unknown
route; add keeper params testing
* add spec
* update swagger
* find replace hard -> swap in comments
* remove unused method
* rename pairs to allowed pools; pool is more commonly used, and
allowedPool makes it more clear what swap parameter is for. In
addition, we won't conflict with Pool data structure for storing a
created pool in the store.
* remove generated link
* missed spec rename
* validate token order for allowed pools
* fix swagger
* json should be snakecase; change allowedPools to allowed_pools
* add legacy types
* add swap genesis to v0_15 migration
* add legacy types
* add swap genesis to v0_15 migration
* migration revisions
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
* keeper todos
* update keeper tests
* type todos
* update types tests
* tx deposit cli cmd
* tx deposit rest
* Swap module simulation scaffolding (#924)
* sims scaffolding
* add noop operation
* genesis revisions
* add param changes
* mvoe persistance methods to main keeper file, consolidate tests
* make helper methods private. they are tested via deposit method, and
unit testing them would make test suite brittle and refactoring
difficult
* use more clear coin variables
* code 1 is reserved, use code 2 and sequence all errors
* remove todo
* Implement deadline for swap module module message. This is implemented in
handler with a interface to easily apply to it to all messages, and
separate msg validation concerns from the keeper
* move allowed pools to params -- let pool and pool_test focus on pool domain logic, not
parameter & governance concerns
* update alias
* add unitless implementatin of constant product liquidity pool to
isolate and enapsulate liquidity logic. Swap methods interfaces are
added, but implementation not yet added
* nits and todos
* add ErrInvalidPool
* add tests for edge cases around pool depletion; add explicit panic for
edge case that results in a pool reserve being zero; handle pool
reinitialization if it is empty
* touch up comments and flush out the rest of assertions
* add data structures for keeper state storage separate from pool domain
objects, and improve structure for easier querying
* rename pool name to pool key for events
* add support for a denominated pool that uses sdk.Coins and sdk.Coin
arguments, keeping tracking of the units in the base pool. This gives
nice separation between pool logic, and coin/denom logic
* refactor keeper to use new records for storage, and implement pool
deposit using the denominated pool
* address previous PR comment - reminder for migration if changing
account permissions
* msg deposit should validate that denoms are not equal
* add godoc comments
* golint and some poolName -> poolID cleanup
* implement adding liquidity to an existing pool
* hardcode pools in sims
* touch up comment
* withdraw keeper logic
* withdraw type updates
* add withdraw msg tx handler
* initial withdraw test
* fix panic
* use new denominated pool with existing shares
* fix: check args on deposit cmd
* add slippage limit check for depositing to an existing pool
* send coins just before event emission
* check liquidity returned is greater than zero for both coins; ensure
returned number of shares are greater than zero
* add deadline to msgwithdraw
* register msgwithdraw
* scaffold msgwithdraw types test
* register the correct msg
* modify swap functions to also return the amount paid for the pool swap
fee. This will be used to calculate slippage and for event tracking
* add slippage types
* add expected withdrawal coins
* calculate slippage against expected coins
* update withdraw keeper tests
* spelling, improve comments on add liquidity math
* typo
* typo
* grammer
* typo / grammer
* remove pool_id from withdraw msg
* add slippage to tx cmd
* TestWithdraw_Partial
* nit
* add withdraw no pool, no deposit record tests
* drop event check on partial withdraw test
* fix broken link
* fix broken link
* resolve merge conflicts
* ensure swap fee can not be equal to 1; add full implementation of swap
pool methods; these implementation ensure that the pool invariant is
always greater or equal to the previous invariant
* refactor duplicated code into private swap methods
* add runtime assertion to always ensure invariant is greater or equal
to the previous invariant sub fee on swaps
* improve comments for base pool swap functions
* add swap exact input and output methods to denominated pool that wrap
the base pool interface for swapping
* comment touch ups
* more comment touchups
* fix msg deposit struct tag (#943)
* use better name for swap calculation private methods
* nits: golint
* fix misspelling in method name
* Add HARD token governance committee for Hard module (#941)
* add hard gov token committee
* revisions: update migration
* revisions: update test/data file
* initial revisions
* add TokenCommittee JSONMarshal test
* fix SetPermissions method
* remove BaseCommittee Type field
* add incentive params to allowed params
* Add SWP token governance committee for Swap module (#946)
* add swp token commitee to migration
* update test, add gen export utility method
* final revisions: add TODO
* remove slippage from withdraw to use min values for coins; add
additional validation test cases
* update alias for swap module
* add withdraw tests to handler for increased coverage; note: first pass,
improvements still yet to be made here
* refact withdraw keeper to use min amounts; panic for cases that do not
happen in normal situations
* lint fixes
* use total shares to track if pool should be deleted; add more in depth
withdraw comment
* add exact args for withdraw cmd
* extract record update methods
* update depositor share record if it exists -- do not overwrite an
existing record; ensures no loss of shares if the same address deposits
more than once
* Swap queries: deposit, pool, pools (#949)
* query deposits types
* implement deposit querier keeper methods
* query deposits CLI
* query deposits REST
* query types for pool/pools
* pool/pools querier keeper methods
* pool/pools CLI
* pool/pools REST
* basic pool/pools query tests
* basic deposit querier test
* iterate share records via owner bytes
* nit: add example for querying deposits by owner only
Co-authored-by: karzak <kjydavis3@gmail.com>
* feat: add REST tx handler for swap LP withdrawals
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: Denali Marsh <denali@kava.io>
Co-authored-by: denalimarsh <denalimarsh@gmail.com>
Co-authored-by: karzak <kjydavis3@gmail.com>
2021-07-13 11:38:15 +00:00
|
|
|
"github.com/kava-labs/kava/x/swap"
|
2020-04-29 14:10:41 +00:00
|
|
|
validatorvesting "github.com/kava-labs/kava/x/validator-vesting"
|
2019-06-20 13:37:57 +00:00
|
|
|
)
|
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
type StoreKeysPrefixes struct {
|
|
|
|
A sdk.StoreKey
|
|
|
|
B sdk.StoreKey
|
|
|
|
Prefixes [][]byte
|
|
|
|
}
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2019-10-04 17:44:28 +00:00
|
|
|
// TestMain runs setup and teardown code before all tests.
|
|
|
|
func TestMain(m *testing.M) {
|
2019-10-10 16:03:26 +00:00
|
|
|
// set prefixes
|
|
|
|
config := sdk.GetConfig()
|
|
|
|
SetBech32AddressPrefixes(config)
|
|
|
|
config.Seal()
|
|
|
|
// load the values from simulation specific flags
|
|
|
|
simapp.GetSimulatorFlags()
|
|
|
|
// run tests
|
|
|
|
exitCode := m.Run()
|
|
|
|
os.Exit(exitCode)
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
|
|
|
|
2019-09-11 22:33:20 +00:00
|
|
|
// fauxMerkleModeOpt returns a BaseApp option to use a dbStoreAdapter instead of
|
|
|
|
// an IAVLStore for faster simulation speed.
|
2019-06-20 13:37:57 +00:00
|
|
|
func fauxMerkleModeOpt(bapp *baseapp.BaseApp) {
|
|
|
|
bapp.SetFauxMerkleMode()
|
|
|
|
}
|
|
|
|
|
2019-09-11 22:33:20 +00:00
|
|
|
// interBlockCacheOpt returns a BaseApp option function that sets the persistent
|
|
|
|
// inter-block write-through cache.
|
|
|
|
func interBlockCacheOpt() func(*baseapp.BaseApp) {
|
|
|
|
return baseapp.SetInterBlockCache(store.NewCommitKVStoreCacheManager())
|
|
|
|
}
|
|
|
|
|
2019-07-18 17:36:31 +00:00
|
|
|
func TestFullAppSimulation(t *testing.T) {
|
2020-04-23 16:35:58 +00:00
|
|
|
config, db, dir, logger, skip, err := simapp.SetupSimulation("leveldb-app-sim", "Simulation")
|
|
|
|
if skip {
|
2019-09-11 22:33:20 +00:00
|
|
|
t.Skip("skipping application simulation")
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
2020-04-23 16:35:58 +00:00
|
|
|
require.NoError(t, err, "simulation setup failed")
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2019-06-20 13:37:57 +00:00
|
|
|
defer func() {
|
|
|
|
db.Close()
|
2020-04-23 16:35:58 +00:00
|
|
|
require.NoError(t, os.RemoveAll(dir))
|
2019-06-20 13:37:57 +00:00
|
|
|
}()
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2020-12-02 17:37:11 +00:00
|
|
|
app := NewApp(logger, db, nil, AppOptions{InvariantCheckPeriod: simapp.FlagPeriodValue}, fauxMerkleModeOpt)
|
2020-04-23 16:35:58 +00:00
|
|
|
require.Equal(t, appName, app.Name())
|
2019-06-20 13:37:57 +00:00
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
// run randomized simulation
|
2019-09-11 22:33:20 +00:00
|
|
|
_, simParams, simErr := simulation.SimulateFromSeed(
|
2020-09-01 15:33:12 +00:00
|
|
|
t, os.Stdout, app.BaseApp, AppStateFn(app.Codec(), app.SimulationManager()),
|
2020-04-23 16:35:58 +00:00
|
|
|
simapp.SimulationOperations(app, app.Codec(), config),
|
|
|
|
app.ModuleAccountAddrs(), config,
|
2019-09-11 22:33:20 +00:00
|
|
|
)
|
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
// export state and simParams before the simulation error is checked
|
|
|
|
err = simapp.CheckExportSimulation(app, config, simParams)
|
|
|
|
require.NoError(t, err)
|
2019-09-11 22:33:20 +00:00
|
|
|
require.NoError(t, simErr)
|
|
|
|
|
|
|
|
if config.Commit {
|
2020-04-23 16:35:58 +00:00
|
|
|
simapp.PrintStats(db)
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-07-18 17:36:31 +00:00
|
|
|
func TestAppImportExport(t *testing.T) {
|
2020-04-23 16:35:58 +00:00
|
|
|
config, db, dir, logger, skip, err := simapp.SetupSimulation("leveldb-app-sim", "Simulation")
|
|
|
|
if skip {
|
2019-09-11 22:33:20 +00:00
|
|
|
t.Skip("skipping application import/export simulation")
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
2020-04-23 16:35:58 +00:00
|
|
|
require.NoError(t, err, "simulation setup failed")
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2019-06-20 13:37:57 +00:00
|
|
|
defer func() {
|
|
|
|
db.Close()
|
2020-04-23 16:35:58 +00:00
|
|
|
require.NoError(t, os.RemoveAll(dir))
|
2019-06-20 13:37:57 +00:00
|
|
|
}()
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2020-12-02 17:37:11 +00:00
|
|
|
app := NewApp(logger, db, nil, AppOptions{InvariantCheckPeriod: simapp.FlagPeriodValue}, fauxMerkleModeOpt)
|
2020-04-23 16:35:58 +00:00
|
|
|
require.Equal(t, appName, app.Name())
|
2019-06-20 13:37:57 +00:00
|
|
|
|
|
|
|
// Run randomized simulation
|
2019-09-11 22:33:20 +00:00
|
|
|
_, simParams, simErr := simulation.SimulateFromSeed(
|
2020-09-01 15:33:12 +00:00
|
|
|
t, os.Stdout, app.BaseApp, AppStateFn(app.Codec(), app.SimulationManager()),
|
2020-04-23 16:35:58 +00:00
|
|
|
simapp.SimulationOperations(app, app.Codec(), config),
|
|
|
|
app.ModuleAccountAddrs(), config,
|
2019-09-11 22:33:20 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
// export state and simParams before the simulation error is checked
|
2020-04-23 16:35:58 +00:00
|
|
|
err = simapp.CheckExportSimulation(app, config, simParams)
|
|
|
|
require.NoError(t, err)
|
2019-09-11 22:33:20 +00:00
|
|
|
require.NoError(t, simErr)
|
2019-06-20 13:37:57 +00:00
|
|
|
|
2019-09-11 22:33:20 +00:00
|
|
|
if config.Commit {
|
2020-04-23 16:35:58 +00:00
|
|
|
simapp.PrintStats(db)
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
|
|
|
|
2019-09-11 22:33:20 +00:00
|
|
|
fmt.Printf("exporting genesis...\n")
|
2019-06-20 13:37:57 +00:00
|
|
|
|
|
|
|
appState, _, err := app.ExportAppStateAndValidators(false, []string{})
|
|
|
|
require.NoError(t, err)
|
2020-04-23 16:35:58 +00:00
|
|
|
|
2019-09-11 22:33:20 +00:00
|
|
|
fmt.Printf("importing genesis...\n")
|
2019-06-20 13:37:57 +00:00
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
_, newDB, newDir, _, _, err := simapp.SetupSimulation("leveldb-app-sim-2", "Simulation-2")
|
|
|
|
require.NoError(t, err, "simulation setup failed")
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2019-06-20 13:37:57 +00:00
|
|
|
defer func() {
|
|
|
|
newDB.Close()
|
2020-04-23 16:35:58 +00:00
|
|
|
require.NoError(t, os.RemoveAll(newDir))
|
2019-06-20 13:37:57 +00:00
|
|
|
}()
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2020-12-02 17:37:11 +00:00
|
|
|
newApp := NewApp(log.NewNopLogger(), newDB, nil, AppOptions{InvariantCheckPeriod: simapp.FlagPeriodValue}, fauxMerkleModeOpt)
|
2020-04-23 16:35:58 +00:00
|
|
|
require.Equal(t, appName, newApp.Name())
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
var genesisState GenesisState
|
|
|
|
err = app.Codec().UnmarshalJSON(appState, &genesisState)
|
2019-09-11 22:33:20 +00:00
|
|
|
require.NoError(t, err)
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
ctxA := app.NewContext(true, abci.Header{Height: app.LastBlockHeight()})
|
2019-09-11 22:33:20 +00:00
|
|
|
ctxB := newApp.NewContext(true, abci.Header{Height: app.LastBlockHeight()})
|
2019-07-18 17:36:31 +00:00
|
|
|
newApp.mm.InitGenesis(ctxB, genesisState)
|
2019-06-20 13:37:57 +00:00
|
|
|
|
2019-09-11 22:33:20 +00:00
|
|
|
fmt.Printf("comparing stores...\n")
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2019-06-20 13:37:57 +00:00
|
|
|
storeKeysPrefixes := []StoreKeysPrefixes{
|
2019-09-11 22:33:20 +00:00
|
|
|
{app.keys[baseapp.MainStoreKey], newApp.keys[baseapp.MainStoreKey], [][]byte{}},
|
|
|
|
{app.keys[auth.StoreKey], newApp.keys[auth.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[staking.StoreKey], newApp.keys[staking.StoreKey],
|
|
|
|
[][]byte{
|
|
|
|
staking.UnbondingQueueKey, staking.RedelegationQueueKey, staking.ValidatorQueueKey,
|
|
|
|
}}, // ordering may change but it doesn't matter
|
|
|
|
{app.keys[slashing.StoreKey], newApp.keys[slashing.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[mint.StoreKey], newApp.keys[mint.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[distr.StoreKey], newApp.keys[distr.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[supply.StoreKey], newApp.keys[supply.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[params.StoreKey], newApp.keys[params.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[gov.StoreKey], newApp.keys[gov.StoreKey], [][]byte{}},
|
2020-04-29 14:10:41 +00:00
|
|
|
{app.keys[auction.StoreKey], newApp.keys[auction.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[bep3.StoreKey], newApp.keys[bep3.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[cdp.StoreKey], newApp.keys[cdp.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[incentive.StoreKey], newApp.keys[incentive.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[kavadist.StoreKey], newApp.keys[kavadist.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[pricefeed.StoreKey], newApp.keys[pricefeed.StoreKey], [][]byte{}},
|
|
|
|
{app.keys[validatorvesting.StoreKey], newApp.keys[validatorvesting.StoreKey], [][]byte{}},
|
2020-05-04 21:17:20 +00:00
|
|
|
{app.keys[committee.StoreKey], newApp.keys[committee.StoreKey], [][]byte{}},
|
Squash merge swap-acceptance branch (#956)
* add failing acceptance test for a user depositing into a pool
* implement GetAccount test helper
* implement swap.MsgDeposit for creating and adding liquidity to a pool
* update aliases, add event types, and fix typo/compiler errors in handler
test
* use only aliases names in handler test (don't use swap types -- ensures
we have run aliasgen), add assertion for even type message
* implement account and module account balance checks in handler test
* fill out handler assertions for testing keeper state and events
* update signed json representation and register swap/MsgDeposit for
proper encoding
* fill out boilerplate to get handler test to compile
* alias gen for pool
* add handling of message type; fill in deposit keeper method for
succesful compile; noop but test assertions now run up to module acc not
nil check
* add module account permissions for swap module -- fixes module account
creation; pass account keeper and supply keeper into swap keeper to
allow the ability to work with user and module accounts
* implement create pool logic for msg deposit; allows creation of a of new
pool, checking params to see if it is allowed. Initi shares are set,
and senders number of shares are stored
* Swap migrations scaffolding (#925)
* swap module scaffolding
* global swap fee
* can't think of a reason for begin blocker; removing for abci.go for now;
* test pair types; refactor pair name logic; simplify pairs validation and
fix stack overflow error
* check comparison
* use test package
* init swap module genesis
* add basic marshall tests
* remove reward apy from pairs
* fix integration helpers
* use max swap fee constant; fix validation of swap fee; add tests to
cover param validation and param set setup
* use noerror over nil
* start genesis tests
* test param set validation mirrors param validation
* add genesis tests
* remove print statement
* add subtests for genesis test cases; add extra querier test for unknown
route; add keeper params testing
* add spec
* update swagger
* find replace hard -> swap in comments
* remove unused method
* rename pairs to allowed pools; pool is more commonly used, and
allowedPool makes it more clear what swap parameter is for. In
addition, we won't conflict with Pool data structure for storing a
created pool in the store.
* remove generated link
* missed spec rename
* validate token order for allowed pools
* fix swagger
* json should be snakecase; change allowedPools to allowed_pools
* add legacy types
* add swap genesis to v0_15 migration
* add legacy types
* add swap genesis to v0_15 migration
* migration revisions
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
* keeper todos
* update keeper tests
* type todos
* update types tests
* tx deposit cli cmd
* tx deposit rest
* Swap module simulation scaffolding (#924)
* sims scaffolding
* add noop operation
* genesis revisions
* add param changes
* mvoe persistance methods to main keeper file, consolidate tests
* make helper methods private. they are tested via deposit method, and
unit testing them would make test suite brittle and refactoring
difficult
* use more clear coin variables
* code 1 is reserved, use code 2 and sequence all errors
* remove todo
* Implement deadline for swap module module message. This is implemented in
handler with a interface to easily apply to it to all messages, and
separate msg validation concerns from the keeper
* move allowed pools to params -- let pool and pool_test focus on pool domain logic, not
parameter & governance concerns
* update alias
* add unitless implementatin of constant product liquidity pool to
isolate and enapsulate liquidity logic. Swap methods interfaces are
added, but implementation not yet added
* nits and todos
* add ErrInvalidPool
* add tests for edge cases around pool depletion; add explicit panic for
edge case that results in a pool reserve being zero; handle pool
reinitialization if it is empty
* touch up comments and flush out the rest of assertions
* add data structures for keeper state storage separate from pool domain
objects, and improve structure for easier querying
* rename pool name to pool key for events
* add support for a denominated pool that uses sdk.Coins and sdk.Coin
arguments, keeping tracking of the units in the base pool. This gives
nice separation between pool logic, and coin/denom logic
* refactor keeper to use new records for storage, and implement pool
deposit using the denominated pool
* address previous PR comment - reminder for migration if changing
account permissions
* msg deposit should validate that denoms are not equal
* add godoc comments
* golint and some poolName -> poolID cleanup
* implement adding liquidity to an existing pool
* hardcode pools in sims
* touch up comment
* withdraw keeper logic
* withdraw type updates
* add withdraw msg tx handler
* initial withdraw test
* fix panic
* use new denominated pool with existing shares
* fix: check args on deposit cmd
* add slippage limit check for depositing to an existing pool
* send coins just before event emission
* check liquidity returned is greater than zero for both coins; ensure
returned number of shares are greater than zero
* add deadline to msgwithdraw
* register msgwithdraw
* scaffold msgwithdraw types test
* register the correct msg
* modify swap functions to also return the amount paid for the pool swap
fee. This will be used to calculate slippage and for event tracking
* add slippage types
* add expected withdrawal coins
* calculate slippage against expected coins
* update withdraw keeper tests
* spelling, improve comments on add liquidity math
* typo
* typo
* grammer
* typo / grammer
* remove pool_id from withdraw msg
* add slippage to tx cmd
* TestWithdraw_Partial
* nit
* add withdraw no pool, no deposit record tests
* drop event check on partial withdraw test
* fix broken link
* fix broken link
* resolve merge conflicts
* ensure swap fee can not be equal to 1; add full implementation of swap
pool methods; these implementation ensure that the pool invariant is
always greater or equal to the previous invariant
* refactor duplicated code into private swap methods
* add runtime assertion to always ensure invariant is greater or equal
to the previous invariant sub fee on swaps
* improve comments for base pool swap functions
* add swap exact input and output methods to denominated pool that wrap
the base pool interface for swapping
* comment touch ups
* more comment touchups
* fix msg deposit struct tag (#943)
* use better name for swap calculation private methods
* nits: golint
* fix misspelling in method name
* Add HARD token governance committee for Hard module (#941)
* add hard gov token committee
* revisions: update migration
* revisions: update test/data file
* initial revisions
* add TokenCommittee JSONMarshal test
* fix SetPermissions method
* remove BaseCommittee Type field
* add incentive params to allowed params
* Add SWP token governance committee for Swap module (#946)
* add swp token commitee to migration
* update test, add gen export utility method
* final revisions: add TODO
* remove slippage from withdraw to use min values for coins; add
additional validation test cases
* update alias for swap module
* add withdraw tests to handler for increased coverage; note: first pass,
improvements still yet to be made here
* refact withdraw keeper to use min amounts; panic for cases that do not
happen in normal situations
* lint fixes
* use total shares to track if pool should be deleted; add more in depth
withdraw comment
* add exact args for withdraw cmd
* extract record update methods
* update depositor share record if it exists -- do not overwrite an
existing record; ensures no loss of shares if the same address deposits
more than once
* Swap queries: deposit, pool, pools (#949)
* query deposits types
* implement deposit querier keeper methods
* query deposits CLI
* query deposits REST
* query types for pool/pools
* pool/pools querier keeper methods
* pool/pools CLI
* pool/pools REST
* basic pool/pools query tests
* basic deposit querier test
* iterate share records via owner bytes
* nit: add example for querying deposits by owner only
Co-authored-by: karzak <kjydavis3@gmail.com>
* feat: add REST tx handler for swap LP withdrawals
Co-authored-by: Nick DeLuca <nickdeluca08@gmail.com>
Co-authored-by: Denali Marsh <denali@kava.io>
Co-authored-by: denalimarsh <denalimarsh@gmail.com>
Co-authored-by: karzak <kjydavis3@gmail.com>
2021-07-13 11:38:15 +00:00
|
|
|
{app.keys[swap.StoreKey], newApp.keys[swap.StoreKey], [][]byte{}},
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
for _, skp := range storeKeysPrefixes {
|
|
|
|
storeA := ctxA.KVStore(skp.A)
|
|
|
|
storeB := ctxB.KVStore(skp.B)
|
2019-09-11 22:33:20 +00:00
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
failedKVAs, failedKVBs := sdk.DiffKVStores(storeA, storeB, skp.Prefixes)
|
2019-09-11 22:33:20 +00:00
|
|
|
require.Equal(t, len(failedKVAs), len(failedKVBs), "unequal sets of key-values to compare")
|
2020-04-29 14:10:41 +00:00
|
|
|
if len(failedKVAs) != 0 {
|
|
|
|
fmt.Printf("found %d non-equal key/value pairs between %s and %s\n", len(failedKVAs), skp.A, skp.B)
|
|
|
|
}
|
2020-04-23 16:35:58 +00:00
|
|
|
require.Equal(t, len(failedKVAs), 0, simapp.GetSimulationLog(skp.A.Name(), app.SimulationManager().StoreDecoders, app.Codec(), failedKVAs, failedKVBs))
|
2019-09-11 22:33:20 +00:00
|
|
|
}
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
|
|
|
|
2019-07-18 17:36:31 +00:00
|
|
|
func TestAppSimulationAfterImport(t *testing.T) {
|
2020-04-23 16:35:58 +00:00
|
|
|
config, db, dir, logger, skip, err := simapp.SetupSimulation("leveldb-app-sim", "Simulation")
|
|
|
|
if skip {
|
2019-09-11 22:33:20 +00:00
|
|
|
t.Skip("skipping application simulation after import")
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
2020-04-23 16:35:58 +00:00
|
|
|
require.NoError(t, err, "simulation setup failed")
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2019-06-20 13:37:57 +00:00
|
|
|
defer func() {
|
|
|
|
db.Close()
|
2020-04-23 16:35:58 +00:00
|
|
|
require.NoError(t, os.RemoveAll(dir))
|
2019-06-20 13:37:57 +00:00
|
|
|
}()
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2020-12-02 17:37:11 +00:00
|
|
|
app := NewApp(logger, db, nil, AppOptions{InvariantCheckPeriod: simapp.FlagPeriodValue}, fauxMerkleModeOpt)
|
2020-04-23 16:35:58 +00:00
|
|
|
require.Equal(t, appName, app.Name())
|
2019-06-20 13:37:57 +00:00
|
|
|
|
2019-09-11 22:33:20 +00:00
|
|
|
// Run randomized simulation
|
|
|
|
stopEarly, simParams, simErr := simulation.SimulateFromSeed(
|
2020-09-01 15:33:12 +00:00
|
|
|
t, os.Stdout, app.BaseApp, AppStateFn(app.Codec(), app.SimulationManager()),
|
2020-04-23 16:35:58 +00:00
|
|
|
simapp.SimulationOperations(app, app.Codec(), config),
|
|
|
|
app.ModuleAccountAddrs(), config,
|
2019-09-11 22:33:20 +00:00
|
|
|
)
|
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
// export state and simParams before the simulation error is checked
|
|
|
|
err = simapp.CheckExportSimulation(app, config, simParams)
|
|
|
|
require.NoError(t, err)
|
2019-09-11 22:33:20 +00:00
|
|
|
require.NoError(t, simErr)
|
|
|
|
|
|
|
|
if config.Commit {
|
2020-04-23 16:35:58 +00:00
|
|
|
simapp.PrintStats(db)
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2019-06-20 13:37:57 +00:00
|
|
|
if stopEarly {
|
2020-04-23 16:35:58 +00:00
|
|
|
fmt.Println("can't export or import a zero-validator genesis, exiting test...")
|
2019-06-20 13:37:57 +00:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
fmt.Printf("exporting genesis...\n")
|
2019-06-20 13:37:57 +00:00
|
|
|
|
|
|
|
appState, _, err := app.ExportAppStateAndValidators(true, []string{})
|
2020-04-23 16:35:58 +00:00
|
|
|
require.NoError(t, err)
|
2019-06-20 13:37:57 +00:00
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
fmt.Printf("importing genesis...\n")
|
2019-06-20 13:37:57 +00:00
|
|
|
|
2020-04-23 16:35:58 +00:00
|
|
|
_, newDB, newDir, _, _, err := simapp.SetupSimulation("leveldb-app-sim-2", "Simulation-2")
|
|
|
|
require.NoError(t, err, "simulation setup failed")
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2019-06-20 13:37:57 +00:00
|
|
|
defer func() {
|
|
|
|
newDB.Close()
|
2020-04-23 16:35:58 +00:00
|
|
|
require.NoError(t, os.RemoveAll(newDir))
|
2019-06-20 13:37:57 +00:00
|
|
|
}()
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2020-12-02 17:37:11 +00:00
|
|
|
newApp := NewApp(log.NewNopLogger(), newDB, nil, AppOptions{InvariantCheckPeriod: simapp.FlagPeriodValue}, fauxMerkleModeOpt)
|
2020-04-23 16:35:58 +00:00
|
|
|
require.Equal(t, appName, newApp.Name())
|
2019-09-11 22:33:20 +00:00
|
|
|
|
2019-06-20 13:37:57 +00:00
|
|
|
newApp.InitChain(abci.RequestInitChain{
|
|
|
|
AppStateBytes: appState,
|
|
|
|
})
|
|
|
|
|
2019-09-11 22:33:20 +00:00
|
|
|
_, _, err = simulation.SimulateFromSeed(
|
2020-09-01 15:33:12 +00:00
|
|
|
t, os.Stdout, newApp.BaseApp, AppStateFn(app.Codec(), app.SimulationManager()),
|
2020-04-23 16:35:58 +00:00
|
|
|
simapp.SimulationOperations(newApp, newApp.Codec(), config),
|
|
|
|
newApp.ModuleAccountAddrs(), config,
|
2019-09-11 22:33:20 +00:00
|
|
|
)
|
|
|
|
require.NoError(t, err)
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func TestAppStateDeterminism(t *testing.T) {
|
2019-09-11 22:33:20 +00:00
|
|
|
if !simapp.FlagEnabledValue {
|
|
|
|
t.Skip("skipping application simulation")
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
|
|
|
|
2019-09-11 22:33:20 +00:00
|
|
|
config := simapp.NewConfigFromFlags()
|
|
|
|
config.InitialBlockHeight = 1
|
|
|
|
config.ExportParamsPath = ""
|
|
|
|
config.OnOperation = false
|
|
|
|
config.AllInvariants = false
|
2020-04-23 16:35:58 +00:00
|
|
|
config.ChainID = helpers.SimAppChainID
|
2019-09-11 22:33:20 +00:00
|
|
|
|
2020-04-16 02:37:22 +00:00
|
|
|
numTimesToRunPerSeed := 2
|
2019-06-20 13:37:57 +00:00
|
|
|
appHashList := make([]json.RawMessage, numTimesToRunPerSeed)
|
|
|
|
|
2020-04-16 20:58:00 +00:00
|
|
|
for j := 0; j < numTimesToRunPerSeed; j++ {
|
|
|
|
logger := log.NewNopLogger()
|
|
|
|
db := dbm.NewMemDB()
|
2020-12-02 17:37:11 +00:00
|
|
|
app := NewApp(logger, db, nil, AppOptions{InvariantCheckPeriod: simapp.FlagPeriodValue}, interBlockCacheOpt())
|
2019-09-11 22:33:20 +00:00
|
|
|
|
2020-04-16 20:58:00 +00:00
|
|
|
fmt.Printf(
|
|
|
|
"running non-determinism simulation; seed %d: attempt: %d/%d\n",
|
|
|
|
config.Seed, j+1, numTimesToRunPerSeed,
|
|
|
|
)
|
2019-09-11 22:33:20 +00:00
|
|
|
|
2020-04-16 20:58:00 +00:00
|
|
|
_, _, err := simulation.SimulateFromSeed(
|
2020-09-01 15:33:12 +00:00
|
|
|
t, os.Stdout, app.BaseApp, AppStateFn(app.Codec(), app.SimulationManager()),
|
2020-04-23 16:35:58 +00:00
|
|
|
simapp.SimulationOperations(app, app.Codec(), config),
|
|
|
|
app.ModuleAccountAddrs(), config,
|
2020-04-16 20:58:00 +00:00
|
|
|
)
|
|
|
|
require.NoError(t, err)
|
2019-09-11 22:33:20 +00:00
|
|
|
|
2020-04-16 20:58:00 +00:00
|
|
|
appHash := app.LastCommitID().Hash
|
|
|
|
appHashList[j] = appHash
|
2019-07-18 17:36:31 +00:00
|
|
|
|
2020-04-16 20:58:00 +00:00
|
|
|
if j != 0 {
|
|
|
|
require.Equal(
|
|
|
|
t, appHashList[0], appHashList[j],
|
|
|
|
"non-determinism in seed %d: attempt: %d/%d\n", config.Seed, j+1, numTimesToRunPerSeed,
|
|
|
|
)
|
2019-06-20 13:37:57 +00:00
|
|
|
}
|
|
|
|
}
|
2020-04-29 14:10:41 +00:00
|
|
|
}
|
2020-09-01 15:33:12 +00:00
|
|
|
|
|
|
|
// AppStateFn returns the initial application state using a genesis or the simulation parameters.
|
|
|
|
// It panics if the user provides files for both of them.
|
|
|
|
// If a file is not given for the genesis or the sim params, it creates a randomized one.
|
|
|
|
// Note: this was copied in from the sdk/simapp/state.go, and modified to not generate genesis times too far in the future.
|
|
|
|
// Dates greater than the year 9000 interfere with new auctions who's EndTime is set to 90000.
|
|
|
|
func AppStateFn(cdc *codec.Codec, simManager *module.SimulationManager) simulation.AppStateFn {
|
|
|
|
return func(r *rand.Rand, accs []simulation.Account, config simulation.Config,
|
|
|
|
) (appState json.RawMessage, simAccs []simulation.Account, chainID string, genesisTimestamp time.Time) {
|
|
|
|
|
|
|
|
if simapp.FlagGenesisTimeValue == 0 {
|
|
|
|
genesisTimestamp = time.Unix(r.Int63n(190288396800), 0) // 1st Jan year 8000
|
|
|
|
} else {
|
|
|
|
genesisTimestamp = time.Unix(simapp.FlagGenesisTimeValue, 0)
|
|
|
|
}
|
|
|
|
|
|
|
|
chainID = config.ChainID
|
|
|
|
switch {
|
|
|
|
case config.ParamsFile != "" && config.GenesisFile != "":
|
|
|
|
panic("cannot provide both a genesis file and a params file")
|
|
|
|
|
|
|
|
case config.GenesisFile != "":
|
|
|
|
// override the default chain-id from simapp to set it later to the config
|
|
|
|
genesisDoc, accounts := simapp.AppStateFromGenesisFileFn(r, cdc, config.GenesisFile)
|
|
|
|
|
|
|
|
if simapp.FlagGenesisTimeValue == 0 {
|
|
|
|
// use genesis timestamp if no custom timestamp is provided (i.e no random timestamp)
|
|
|
|
genesisTimestamp = genesisDoc.GenesisTime
|
|
|
|
}
|
|
|
|
|
|
|
|
appState = genesisDoc.AppState
|
|
|
|
chainID = genesisDoc.ChainID
|
|
|
|
simAccs = accounts
|
|
|
|
|
|
|
|
case config.ParamsFile != "":
|
|
|
|
appParams := make(simulation.AppParams)
|
|
|
|
bz, err := ioutil.ReadFile(config.ParamsFile)
|
|
|
|
if err != nil {
|
|
|
|
panic(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
cdc.MustUnmarshalJSON(bz, &appParams)
|
|
|
|
appState, simAccs = simapp.AppStateRandomizedFn(simManager, r, cdc, accs, genesisTimestamp, appParams)
|
|
|
|
|
|
|
|
default:
|
|
|
|
appParams := make(simulation.AppParams)
|
|
|
|
appState, simAccs = simapp.AppStateRandomizedFn(simManager, r, cdc, accs, genesisTimestamp, appParams)
|
|
|
|
}
|
|
|
|
|
|
|
|
return appState, simAccs, chainID, genesisTimestamp
|
|
|
|
}
|
|
|
|
}
|